[PATCH 1/2] libosmocore: remove GSM-specific functions (they now belong to libosmo-gsm)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Thu Mar 17 21:29:23 UTC 2011


Hi Sylvain,

On 17/03/11 22:15, Sylvain Munaut wrote:
> Hi,
> 
>> I forgot to say that VTY code still remains in libosmocore, I'll study
>> if it can be interesting in a new library (I can do this later, once
>> this patches are applied, of course).
> 
> gsmtap is a misnomer, but we now use it for TETRA as well ...
> crc16 possibly common as well (altough not sure).

So you're proposing that this should go back to libosmocore, right?

> In general, if we have functions that are common to several protocols
> but are not really 'system' stuff like select/timer or stuff like
> that, where should we put them ?
>
> Keep them in libosmocore ?  (like a include/osmocom/utils or also in 'core' ?)

I started with this split, but we can continue with more splits, of
course. We can put these into libosmo-utils (or libosmo-base), I don't
mind the name.

> Also, for future enhancement (future patches, just mentioning it here
> since it's kinda related to the whole library cleanup), Harald
> mentionned to replace the include/osmocore by include/osmocom/core
> (like it was done for vty / code / ...)

Thanks, I'll make follow-up patches for that once these have been
applied (I'm trying not to mix things by splitting things in logical
changes, to make review easier).




More information about the OpenBSC mailing list