Time in MM Info [patch]

[Harald Welte]

Hi Gus,

On Wed, Nov 30, 2011 at 03:13:04PM -0800, Gus Bourg wrote:
> Attached is a patch to support sending time to the device.

thanks a lot for the patch.

however, some remarks:

1) We actually do support ranges with negative numbers in the syntax,
   after commit 33f0fc3c9565308044c934c9e0c1bb81c1a26311 in libosmocore
   you can do something like "timezone <-19-19> (0|15|30|45)"
   which I believe would be a more human-friendly way of entering it in
   hours and minutes.

2) the internal storage could thus also be a simple "int timezone",
   which gets filled from the hour and minute part of the abovementioned
   command syntax.

3) please make sure to use a default of "cur_time->tm_gmtoff" in case
   the config file doesn't use per-BTS timezones.  So another "int
   timezone_bts_specific" member might be applicable.

4) please make sure to use tab instead of "        " (sequence of 8
   whitespaces), or use a script that automatically takes care of that.

5) the "timezone" vty line should only be printed if the user actually
   configured it (i.e. timezone_bts_specific == 1).

6) there needs to be a way to completely remove the timezone statement,
   most likely a "no timezone" VTY command in the BTS node.

Regards,
	Harald

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)