AW: AW: first patch: mISDN handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther zecke at selfish.org
Thu Apr 23 20:08:58 UTC 2009


On Thursday 23 April 2009 10:33:52 Andreas.Eversberg wrote:
> ok, next time i will split the patches for easier understanding. if you
> require splitting of my first patch, let me know.


Yes, please. Split out the improved error handling (more if's, printf with 
__func__), and for the E1 part try to not have commented out code in the 
patch. The only question I really have is why do we need init_af_isdn, is it 
really worth to add a depenency on mISDNuser for it?

z.






More information about the OpenBSC mailing list