<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/26701">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">e1d: reliably detect EOF (HDLC-FCS mode)<br><br>This patch makes e1d reliably detect EOF on client sockets while in<br>HDLC-FCS mode.<br><br>Change-Id: I0260360643f723f7c721ae67c47dce8df7778694<br>---<br>M src/mux_demux.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mux_demux.c b/src/mux_demux.c</span><br><span>index bceeecd..341256a 100644</span><br><span>--- a/src/mux_demux.c</span><br><span>+++ b/src/mux_demux.c</span><br><span>@@ -62,7 +62,7 @@</span><br><span>                       LOGPTS(ts, DXFR, LOGL_DEBUG, "RX Message: %d [ %s]\n",</span><br><span>                             rv, osmo_hexdump(ts->hdlc.rx_buf, rv));</span><br><span>                   rv = write(ts->fd, ts->hdlc.rx_buf, bytes_to_write);</span><br><span style="color: hsl(0, 100%, 40%);">-                      if (rv < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (rv <= 0)</span><br><span>                              return rv;</span><br><span>           } else  if (rv < 0 && ts->id == 4) {</span><br><span>                   LOGPTS(ts, DXFR, LOGL_ERROR, "ERR RX: %d %d %d [ %s]\n",</span><br><span>@@ -97,7 +97,7 @@</span><br><span>                                       rv, osmo_hexdump(ts->hdlc.tx_buf, rv));</span><br><span>                           ts->hdlc.tx_len = rv;</span><br><span>                             ts->hdlc.tx_ofs = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                 } else if (rv < 0 && errno != EAGAIN)</span><br><span style="color: hsl(120, 100%, 40%);">+                      } else if ((rv < 0 && errno != EAGAIN) || rv == 0)</span><br><span>                                return rv;</span><br><span>           }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/26701">change 26701</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/26701"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0260360643f723f7c721ae67c47dce8df7778694 </div>
<div style="display:none"> Gerrit-Change-Number: 26701 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>