<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/26700">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">e1d: reliably detect EOF in _e1_ts_{read,write} (RAW mode)<br><br>This allows us to reliably detect client disconnection at least in<br>the case of RAW mode channels.  Even with this patch applied, e1d<br>still fails to reliably detect client disconnect on HDLC-FCS channels.<br><br>Change-Id: Ifb8b91d39b394f9c10c859f3adac85ea47b7653f<br>---<br>M src/mux_demux.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mux_demux.c b/src/mux_demux.c</span><br><span>index dffc798..bceeecd 100644</span><br><span>--- a/src/mux_demux.c</span><br><span>+++ b/src/mux_demux.c</span><br><span>@@ -147,7 +147,7 @@</span><br><span>                 break;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (l < 0 && errno != EAGAIN) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if ((l < 0 && errno != EAGAIN) || l == 0) {</span><br><span>               LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during read: %s\n",</span><br><span>                      strerror(errno));</span><br><span>            e1_ts_stop(ts);</span><br><span>@@ -293,7 +293,7 @@</span><br><span>                break;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (rv < 0 && errno != EAGAIN) {</span><br><span style="color: hsl(120, 100%, 40%);">+   if ((rv < 0 && errno != EAGAIN) || rv == 0) {</span><br><span>             LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during write: %s\n",</span><br><span>                     strerror(errno));</span><br><span>            e1_ts_stop(ts);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/26700">change 26700</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/26700"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb8b91d39b394f9c10c859f3adac85ea47b7653f </div>
<div style="display:none"> Gerrit-Change-Number: 26700 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>