<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/26684">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">iuup: Fix signed/unsigned loop counter control flow issue<br><br>The use of an unsinged integer as for loop counter variable doesn't<br>work when counting down and comparing with >= 0.  The existing code<br>would be an infinite loop if it wasn't for the (data dependent) break<br>condition:<br><br>>>>     CID 243259:  Control flow issues  (NO_EFFECT)<br>>>>     This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "i >= 0U".<br>572             for (i = 15; i >= 0; i--) {<br>573                     if (match_mask & (1<<i)) {<br>574                             iui->mode_version = i;<br>575                             break;<br>576                     }<br><br>Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf<br>Closes: CID#243259<br>---<br>M src/gsm/iuup.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/26684/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c</span><br><span>index 159e533..b838dc6 100644</span><br><span>--- a/src/gsm/iuup.c</span><br><span>+++ b/src/gsm/iuup.c</span><br><span>@@ -493,7 +493,7 @@</span><br><span>         struct iuup_ctrl_init_tail *itail;</span><br><span>   enum iuup_error_cause err_cause;</span><br><span>     uint8_t num_rfci = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-   unsigned int i;</span><br><span style="color: hsl(120, 100%, 40%);">+       int i;</span><br><span>       bool is_last;</span><br><span>        uint16_t remote_mask, match_mask;</span><br><span>    struct osmo_iuup_tnl_prim *resp;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/26684">change 26684</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/26684"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf </div>
<div style="display:none"> Gerrit-Change-Number: 26684 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>