<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26678">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: Rename variable payload=>payload_type<br><br>Using "payload" there is misleading, the proper naming is payload type,<br>a well known term for RTP.<br><br>Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870<br>---<br>M src/libosmo-mgcp/mgcp_sdp.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c</span><br><span>index a36c6d2..98b3099 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_sdp.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_sdp.c</span><br><span>@@ -98,7 +98,7 @@</span><br><span> /* Helper function to update codec map information with additional data from</span><br><span>  * SDP, called from: mgcp_parse_sdp_data() */</span><br><span> static void codecs_update(void *ctx, struct sdp_rtp_map *codecs, int used,</span><br><span style="color: hsl(0, 100%, 40%);">-                     int payload, const char *audio_name)</span><br><span style="color: hsl(120, 100%, 40%);">+                          int payload_type, const char *audio_name)</span><br><span> {</span><br><span>     int i;</span><br><span> </span><br><span>@@ -110,7 +110,7 @@</span><br><span>             /* Note: We can only update payload codecs that already exist</span><br><span>                 * in our codec list. If we get an unexpected payload type,</span><br><span>           * we just drop it */</span><br><span style="color: hsl(0, 100%, 40%);">-           if (codecs[i].payload_type != payload)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (codecs[i].payload_type != payload_type)</span><br><span>                  continue;</span><br><span> </span><br><span>                if (sscanf(audio_name, "%63[^/]/%d/%d",</span><br><span>@@ -127,7 +127,7 @@</span><br><span>              return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGP(DLMGCP, LOGL_ERROR, "Unconfigured PT(%d) with %s\n", payload,</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DLMGCP, LOGL_ERROR, "Unconfigured PT(%d) with %s\n", payload_type,</span><br><span>         audio_name);</span><br><span> }</span><br><span> </span><br><span>@@ -334,7 +334,7 @@</span><br><span>     void *tmp_ctx = talloc_new(NULL);</span><br><span>    struct mgcp_rtp_end *rtp;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   int payload;</span><br><span style="color: hsl(120, 100%, 40%);">+  int payload_type;</span><br><span>    int ptime, ptime2 = 0;</span><br><span>       char audio_name[64];</span><br><span>         int port, rc;</span><br><span>@@ -355,8 +355,8 @@</span><br><span>                  /* skip these SDP attributes */</span><br><span>                      break;</span><br><span>               case 'a':</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (sscanf(line, "a=rtpmap:%d %63s", &payload, audio_name) == 2) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                codecs_update(tmp_ctx, codecs, codecs_used, payload, audio_name);</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (sscanf(line, "a=rtpmap:%d %63s", &payload_type, audio_name) == 2) {</span><br><span style="color: hsl(120, 100%, 40%);">+                         codecs_update(tmp_ctx, codecs, codecs_used, payload_type, audio_name);</span><br><span>                               break;</span><br><span>                       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26678">change 26678</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/26678"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 </div>
<div style="display:none"> Gerrit-Change-Number: 26678 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>