<p><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac">File configure.ac:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace">P</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">will we need ASN.1 decoding/encoding in the bsc-nat?  I'm currently a bit surprised and cannot think of any part that would require it.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh">File contrib/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace">osm</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">does not include libasn1c which configure.ac is requiring (probably wrongly so).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in">File contrib/osmo-bsc-nat.spec.in:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace">Bui</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why would we need libosmogb here? configure.ac doesn't list it, and I cannot think of a reason.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658">change 26658</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc-nat </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e </div>
<div style="display:none"> Gerrit-Change-Number: 26658 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 22 Dec 2021 14:29:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>