<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26665">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_ss7_instance_destroy: use for_each_entry_safe<br><br>Fix segfault in each loop.<br><br>Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216<br>---<br>M src/osmo_ss7.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/65/26665/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 649e3f7..99536d3 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -410,20 +410,20 @@</span><br><span>  *  \param[in] inst SS7 Instance to be destroyed */</span><br><span> void osmo_ss7_instance_destroy(struct osmo_ss7_instance *inst)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   struct osmo_ss7_linkset *lset;</span><br><span style="color: hsl(0, 100%, 40%);">-  struct osmo_ss7_as *as;</span><br><span style="color: hsl(0, 100%, 40%);">- struct osmo_ss7_asp *asp;</span><br><span style="color: hsl(120, 100%, 40%);">+     struct osmo_ss7_linkset *lset, *lset2;</span><br><span style="color: hsl(120, 100%, 40%);">+        struct osmo_ss7_as *as, *as2;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct osmo_ss7_asp *asp, *asp2;</span><br><span> </span><br><span>         OSMO_ASSERT(ss7_initialized);</span><br><span>        LOGSS7(inst, LOGL_INFO, "Destroying SS7 Instance\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     llist_for_each_entry(asp, &inst->asp_list, list)</span><br><span style="color: hsl(120, 100%, 40%);">+       llist_for_each_entry_safe(asp, asp2, &inst->asp_list, list)</span><br><span>           osmo_ss7_asp_destroy(asp);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  llist_for_each_entry(as, &inst->as_list, list)</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_for_each_entry_safe(as, as2, &inst->as_list, list)</span><br><span>              osmo_ss7_as_destroy(as);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    llist_for_each_entry(lset, &inst->linksets, list)</span><br><span style="color: hsl(120, 100%, 40%);">+      llist_for_each_entry_safe(lset, lset2, &inst->linksets, list)</span><br><span>                 osmo_ss7_linkset_destroy(lset);</span><br><span> </span><br><span>  llist_del(&inst->list);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26665">change 26665</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26665"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 </div>
<div style="display:none"> Gerrit-Change-Number: 26665 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>