<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26647">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: add missing return -EINVAL statements<br><br>The checks that make sure that an ARFCN falls in the correct range do<br>not return with -EINVAL as they should, instead nothing happens. (Only<br>the check for GSM1800 is corrct)<br><br>Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff<br>Related: SYS#5369<br>---<br>M src/osmo-bsc/bts.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index c4ae518..2ce0344 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -441,6 +441,7 @@</span><br><span>             if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) {</span><br><span>                        LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n",</span><br><span>                       bts->nr, bts->c0->arfcn);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return -EINVAL;</span><br><span>              }</span><br><span>            break;</span><br><span>       case GSM_BAND_900:</span><br><span>@@ -448,16 +449,19 @@</span><br><span>               bts->c0->arfcn > 1023)  {</span><br><span>                       LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n",</span><br><span>                        bts->nr, bts->c0->arfcn);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return -EINVAL;</span><br><span>              }</span><br><span>            break;</span><br><span>       case GSM_BAND_850:</span><br><span>           if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) {</span><br><span>                        LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n",</span><br><span>                        bts->nr, bts->c0->arfcn);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return -EINVAL;</span><br><span>              }</span><br><span>            break;</span><br><span>       default:</span><br><span>             LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+                return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span>        /* Verify the physical channel mapping */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26647">change 26647</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26647"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff </div>
<div style="display:none"> Gerrit-Change-Number: 26647 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>