<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn">File library/Osmocom_VTY_Functions.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn@246">Patch Set #1, Line 246:</a> <code style="font-family:monospace,monospace">type record of charstring StrList;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would make it 'private'.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn@252">Patch Set #1, Line 252:</a> <code style="font-family:monospace,monospace">                                       integer attempts := 5, float wait_time := 3.0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This line needs to be aligned.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn@254">Patch Set #1, Line 254:</a> <code style="font-family:monospace,monospace">"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No semicolon?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618">change 26618</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iafe720a4931270e868f40c4f623d10bb9c14dc80 </div>
<div style="display:none"> Gerrit-Change-Number: 26618 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 18 Dec 2021 00:10:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>