<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp: Fix possible null pointer dereference<br><br>Closes: Coverity CID#242771<br>Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985<br>---<br>M src/osmo-hnodeb/gtp.c<br>1 file changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/05/26605/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c</span><br><span>index 22d4074..f7d9a14 100644</span><br><span>--- a/src/osmo-hnodeb/gtp.c</span><br><span>+++ b/src/osmo-hnodeb/gtp.c</span><br><span>@@ -79,12 +79,18 @@</span><br><span>        struct hnb *hnb;</span><br><span>     int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (!conn || !conn->ue->conn_ps.active) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGUE(conn->ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                packet, len);</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!conn) {</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u with no conn!\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   packet, len);</span><br><span>           return -EINVAL;</span><br><span>      }</span><br><span>    ue = conn->ue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!ue->conn_ps.active) {</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n",</span><br><span style="color: hsl(120, 100%, 40%);">+               packet, len);</span><br><span style="color: hsl(120, 100%, 40%);">+           return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span>    hnb = ue->hnb;</span><br><span> </span><br><span>        LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605">change 26605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hnodeb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 </div>
<div style="display:none"> Gerrit-Change-Number: 26605 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>