<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: fix ho-out test failures: cleanup neighbor cfg cruft<br><br>In the out-of-this-BSC handover tests, a neighbor config of LAC 99 left<br>behind from a previous test obstructed the test from working:<br><br> % BTS 0 already had neighbor LAC:99 ARFCN-BSIC:123-45<br> % ERROR: duplicate Cell ID in neighbor config, with differing ARFCN+BSIC: LAC:99 ARFCN-BSIC:123-any<br><br>Add a 'no neighbor lac 99' before configuring the neighbor via VTY.<br><br>Also add the missing neighbor config to<br>f_tc_srvcc_eutran_to_geran_ho_out_main().<br><br>Affects tests:<br>BSC_Tests.TC_ho_out_of_this_bsc<br>BSC_Tests.TC_srvcc_eutran_to_geran_ho_out<br>BSC_Tests.TC_srvcc_eutran_to_geran_ho_out_forbid_fast_return<br><br>Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 14 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/26616/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 0c71581..97aff9e 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -5616,6 +5616,7 @@</span><br><span>                   "handover 1",</span><br><span>                      "handover algorithm 2",</span><br><span>                    "handover2 window rxlev averaging 1",</span><br><span style="color: hsl(120, 100%, 40%);">+               "no neighbors",</span><br><span>                    "neighbor lac 99 arfcn 123 bsic any"});</span><br><span>       f_vty_transceive(BSCVTY, "drop bts connection 0 oml");</span><br><span> </span><br><span>@@ -5687,7 +5688,7 @@</span><br><span>         var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span>       f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+        f_bts_0_cfg(BSCVTY, {"no neighbor lac 99", "neighbor lac 99 arfcn 123 bsic any"});</span><br><span>       f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span>        BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -5731,7 +5732,7 @@</span><br><span>   var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span>       f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+        f_bts_0_cfg(BSCVTY, {"no neighbor lac 99", "neighbor lac 99 arfcn 123 bsic any"});</span><br><span>       f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span>        BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -5813,7 +5814,7 @@</span><br><span>   var template PDU_BSSAP exp_compl := f_gen_exp_compl();</span><br><span>       f_establish_fully(ass_req, exp_compl);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+        f_bts_0_cfg(BSCVTY, {"no neighbor lac 99", "neighbor lac 99 arfcn 123 bsic any"});</span><br><span>       f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span> </span><br><span>        BSSAP.receive(tr_BSSMAP_HandoverRequired);</span><br><span>@@ -6099,6 +6100,16 @@</span><br><span>  var MSC_ConnHdlr vc_conn;</span><br><span>    var TestHdlrParams pars := f_gen_test_hdlr_pars();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        f_init_vty();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY,</span><br><span style="color: hsl(120, 100%, 40%);">+               {"neighbor-list mode automatic",</span><br><span style="color: hsl(120, 100%, 40%);">+                     "handover 1",</span><br><span style="color: hsl(120, 100%, 40%);">+               "handover algorithm 2",</span><br><span style="color: hsl(120, 100%, 40%);">+                     "handover2 window rxlev averaging 1",</span><br><span style="color: hsl(120, 100%, 40%);">+               "no neighbors",</span><br><span style="color: hsl(120, 100%, 40%);">+                     "neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+        f_vty_transceive(BSCVTY, "drop bts connection 0 oml");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   f_init(1, true);</span><br><span>     if (disable_fast_return) {</span><br><span>           f_vty_allow_srvcc_fast_return(true, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616">change 26616</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359 </div>
<div style="display:none"> Gerrit-Change-Number: 26616 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>