<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix several Coverity found issues<br><br>Closes: CID#242770<br>Closes: CID#242769<br>Closes: CID#242767<br>Change-Id: I6d73a970919889953539fbacc601d679d7ec4113<br>---<br>M src/osmo-hnodeb/gtp.c<br>M src/osmo-hnodeb/rua.c<br>2 files changed, 11 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/95/26595/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c</span><br><span>index 4695ea9..b8bfebc 100644</span><br><span>--- a/src/osmo-hnodeb/gtp.c</span><br><span>+++ b/src/osmo-hnodeb/gtp.c</span><br><span>@@ -45,14 +45,15 @@</span><br><span> {</span><br><span>  struct hnb_gtp_prim *gtp_prim;</span><br><span>       struct hnb_ue *ue = lib->priv;</span><br><span style="color: hsl(0, 100%, 40%);">-       struct hnb *hnb = ue->hnb;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct hnb *hnb;</span><br><span>     int rc;</span><br><span> </span><br><span>  if (!ue || !ue->conn_ps.active) {</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n",</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n",</span><br><span>                   packet, len);</span><br><span>          return -EINVAL;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     hnb = ue->hnb;</span><br><span> </span><br><span>        LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len);</span><br><span>         gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len);</span><br><span>@@ -180,18 +181,19 @@</span><br><span> int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len)</span><br><span> {</span><br><span>        int rc;</span><br><span style="color: hsl(0, 100%, 40%);">- struct hnb *hnb = ue->hnb;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   if (!hnb->gtp.gsn) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n");</span><br><span style="color: hsl(0, 100%, 40%);">-            return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+     struct hnb *hnb;</span><br><span> </span><br><span>         if (!ue || !ue->conn_ps.pdp_lib) {</span><br><span>                LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n");</span><br><span>             return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ hnb = ue->hnb;</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!hnb->gtp.gsn) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len);</span><br><span>  return rc;</span><br><span> }</span><br><span>diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c</span><br><span>index 3a73f0c..5b225de 100644</span><br><span>--- a/src/osmo-hnodeb/rua.c</span><br><span>+++ b/src/osmo-hnodeb/rua.c</span><br><span>@@ -140,6 +140,7 @@</span><br><span>       case RUA_ProcedureCode_id_DirectTransfer:</span><br><span>            LOGP(DRUA, LOGL_INFO, "RUA rx Initiating DirectTransfer\n");</span><br><span>               hnb_rua_dt_handle(hnb, &init->value);</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       default:</span><br><span>             LOGP(DRUA, LOGL_INFO, "RUA rx unknown Initiating message\n");</span><br><span>              break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595">change 26595</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hnodeb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 </div>
<div style="display:none"> Gerrit-Change-Number: 26595 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>