<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use alive-type components for "infrastructure" components<br><br>According to feedback received from TITAN developers in<br>https://www.eclipse.org/forums/index.php?t=msg&th=1106652&goto=1848616&#msg_1848616<br>the use of alive-type components has the following advantage:<br><br>> Also the DTE during the shutdown can be avoided to use alive type<br>> components. The test ports of the alive components are not<br>> disconnected/unmapped when the component finished only when killed or<br>> the MTC terminated.<br><br>So the idea of this patch is to use alive-type components for all the<br>underlying infrastructure, such as the *_Emulation_CT starting from M3UA<br>to SCCP and further up the stack. This way, only the MTC and the<br>highest level of components (such as ConnHdlr) remain as normal<br>components.<br><br>The hope is that using more alive-type components in the lower protocol<br>layer emulations will reduce the probability of DTE during shutdown if<br>some message is received during the component shutdown after the MTC<br>has completed.<br><br>Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04<br>---<br>M bsc/BSC_Tests.ttcn<br>M gbproxy/GBProxy_Tests.ttcn<br>M library/BSSAP_LE_Adapter.ttcn<br>3 files changed, 11 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index c2ea258..0c71581 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -916,12 +916,12 @@</span><br><span> timer T := 10.0;</span><br><span> </span><br><span> clnt.id := "IPA" & int2str(i) & "-RSL";</span><br><span style="color: hsl(0, 100%, 40%);">- clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA");</span><br><span style="color: hsl(120, 100%, 40%);">+ clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA") alive;</span><br><span> clnt.ccm_pars := c_IPA_default_ccm_pars;</span><br><span> clnt.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator";</span><br><span> clnt.ccm_pars.unit_id := int2str(1234+i) & "/0/0";</span><br><span> if (handler_mode) {</span><br><span style="color: hsl(0, 100%, 40%);">- clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL");</span><br><span style="color: hsl(120, 100%, 40%);">+ clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL") alive;</span><br><span> connect(clnt.vc_RSL:CCHAN_PT, self:RSL_CCHAN[i]);</span><br><span> }</span><br><span> </span><br><span>@@ -1024,7 +1024,7 @@</span><br><span> multi_conn_mode := (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER)</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- vc_MGCP := MGCP_Emulation_CT.create(id);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_MGCP := MGCP_Emulation_CT.create(id) alive;</span><br><span> vc_MGCP.start(MGCP_Emulation.main(ops, mgcp_pars, id));</span><br><span> }</span><br><span> </span><br><span>@@ -3569,7 +3569,7 @@</span><br><span> timer T := 10.0;</span><br><span> </span><br><span> bts[0].rsl.id := "IPA-0-RSL";</span><br><span style="color: hsl(0, 100%, 40%);">- bts[0].rsl.vc_IPA := IPA_Emulation_CT.create(bts[0].rsl.id & "-IPA");</span><br><span style="color: hsl(120, 100%, 40%);">+ bts[0].rsl.vc_IPA := IPA_Emulation_CT.create(bts[0].rsl.id & "-IPA") alive;</span><br><span> bts[0].rsl.ccm_pars := c_IPA_default_ccm_pars;</span><br><span> bts[0].rsl.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator";</span><br><span> bts[0].rsl.ccm_pars.unit_id := "99/0/0"; /* value which is unknown at BTS */</span><br><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index ddf98a9..3f822c2 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -447,8 +447,8 @@</span><br><span> private function f_init_gb_pcu(inout GbInstance gb, charstring id, integer offset) runs on test_CT {</span><br><span> var charstring ns_id := id & "-NS(PCU[" & int2str(offset) & "])";</span><br><span> var charstring bssgp_id := id & "-BSSGP(PCU[" & int2str(offset) & "])";</span><br><span style="color: hsl(0, 100%, 40%);">- gb.vc_NS := NS_CT.create(ns_id);</span><br><span style="color: hsl(0, 100%, 40%);">- gb.vc_BSSGP := BSSGP_CT.create(bssgp_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ gb.vc_NS := NS_CT.create(ns_id) alive;</span><br><span style="color: hsl(120, 100%, 40%);">+ gb.vc_BSSGP := BSSGP_CT.create(bssgp_id) alive;</span><br><span> /* connect lower end of BSSGP emulation with NS upper port */</span><br><span> connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP);</span><br><span> </span><br><span>@@ -470,8 +470,8 @@</span><br><span> private function f_init_gb_sgsn(inout GbInstance gb, charstring id, integer offset) runs on test_CT {</span><br><span> var charstring ns_id := id & "-NS(SGSN[" & int2str(offset) & "])";</span><br><span> var charstring bssgp_id := id & "-BSSGP(SGSN[" & int2str(offset) & "])";</span><br><span style="color: hsl(0, 100%, 40%);">- gb.vc_NS := NS_CT.create(ns_id);</span><br><span style="color: hsl(0, 100%, 40%);">- gb.vc_BSSGP := BSSGP_CT.create(bssgp_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ gb.vc_NS := NS_CT.create(ns_id) alive;</span><br><span style="color: hsl(120, 100%, 40%);">+ gb.vc_BSSGP := BSSGP_CT.create(bssgp_id) alive;</span><br><span> /* connect lower end of BSSGP emulation with NS upper port */</span><br><span> connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP);</span><br><span> </span><br><span>diff --git a/library/BSSAP_LE_Adapter.ttcn b/library/BSSAP_LE_Adapter.ttcn</span><br><span>index dba8841..256d8fa 100644</span><br><span>--- a/library/BSSAP_LE_Adapter.ttcn</span><br><span>+++ b/library/BSSAP_LE_Adapter.ttcn</span><br><span>@@ -85,13 +85,13 @@</span><br><span> ops.sccp_addr_peer := ba.sccp_addr_peer;</span><br><span> </span><br><span> /* create components */</span><br><span style="color: hsl(0, 100%, 40%);">- ba.vc_SCCP := SCCP_CT.create(id & "-SCCP");</span><br><span style="color: hsl(120, 100%, 40%);">+ ba.vc_SCCP := SCCP_CT.create(id & "-SCCP") alive;</span><br><span> if (isvalue(ops)) {</span><br><span style="color: hsl(0, 100%, 40%);">- ba.vc_BSSAP_LE := BSSAP_LE_Emulation_CT.create(id & "-BSSAP_LE");</span><br><span style="color: hsl(120, 100%, 40%);">+ ba.vc_BSSAP_LE := BSSAP_LE_Emulation_CT.create(id & "-BSSAP_LE") alive;</span><br><span> } else {</span><br><span> ba.vc_BSSAP_LE := null;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- ba.vc_M3UA := M3UA_CT.create(id & "-M3UA");</span><br><span style="color: hsl(120, 100%, 40%);">+ ba.vc_M3UA := M3UA_CT.create(id & "-M3UA") alive;</span><br><span> map(ba.vc_M3UA:SCTP_PORT, system:sctp);</span><br><span> /* connect MTP3 service provider (M3UA) to lower side of SCCP */</span><br><span> connect(ba.vc_M3UA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486">change 26486</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 </div>
<div style="display:none"> Gerrit-Change-Number: 26486 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>