<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars()<br><br>Using the same IMSI in each test case makes it harder to correlate<br>subscriber connections in the SUT with particular test cases.  A<br>good example is a problem described in OS#5337: some test cases<br>create dangling subscriber entries that never got released:<br><br>  OsmoBSC# show subscriber all<br>   IMSI             TMSI      Use<br>   001019876543210  ffffffff  3 (3*paging-start)<br>   001010000100001  ffffffff  1 (conn)<br><br>With this patch I am getting the following output:<br><br>  OsmoBSC# show subscriber all<br>   IMSI             TMSI      Use<br>   001016017428234  ffffffff  1 (paging-start)<br>   001014631230680  ffffffff  1 (paging-start)<br>   001011161500382  ffffffff  1 (paging-start)<br>   001010000100001  ffffffff  1 (conn)<br><br>so I was able to correlate the following test cases:<br><br>* (001016017428234) TC_lcs_loc_req_for_active_ms_ta_req,<br>* (001014631230680) TC_lcs_loc_req_for_active_ms_le_timeout2,<br>* (001011161500382) TC_cm_service_during_lcs_loc_req,<br>* (001010000100001) TC_no_msc.<br><br>Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927<br>Related: OS#5337<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index e7c4599..c2ea258 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -720,6 +720,9 @@</span><br><span>      pars.exp_ms_power_level := mp_exp_ms_power_level;</span><br><span>    pars.mscpool.bssap_idx := bssap_idx;</span><br><span>         pars.expect_tsc := BTS_TSC[0];</span><br><span style="color: hsl(120, 100%, 40%);">+        pars.imsi := f_rnd_imsi('00101'H);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  log(testcasename(), ": using IMSI ", pars.imsi);</span><br><span> </span><br><span>       return pars;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506">change 26506</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 </div>
<div style="display:none"> Gerrit-Change-Number: 26506 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>