<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/26464">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: checkpatch_osmo: ignore VOLATILE<br><br>The warning about potentially using volatile wrong is not useful for us,<br>it makes sense to use it in embedded projects.<br><br>Related: OS#5087<br>Related: https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html<br>Related: https://gerrit.osmocom.org/c/simtrace2/+/26463<br>Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69<br>---<br>M lint/checkpatch/checkpatch_osmo.sh<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>index 126a8b4..ae66e71 100755</span><br><span>--- a/lint/checkpatch/checkpatch_osmo.sh</span><br><span>+++ b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>@@ -73,6 +73,7 @@</span><br><span> # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429)</span><br><span> # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345)</span><br><span> # * UNSPECIFIED_INT: not followed (doesn't seem useful for us)</span><br><span style="color: hsl(120, 100%, 40%);">+# * VOLATILE: using volatile makes sense in embedded projects so this warning is not useful for us</span><br><span> </span><br><span> cd "$PROJECT_DIR"</span><br><span> </span><br><span>@@ -109,6 +110,7 @@</span><br><span> --ignore UNNECESSARY_BREAK \</span><br><span> --ignore UNNECESSARY_INT \</span><br><span> --ignore UNSPECIFIED_INT \</span><br><span style="color: hsl(120, 100%, 40%);">+ --ignore VOLATILE \</span><br><span> --max-line-length 120 \</span><br><span> --no-signoff \</span><br><span> --no-tree \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/26464">change 26464</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/26464"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 </div>
<div style="display:none"> Gerrit-Change-Number: 26464 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>