<p style="white-space: pre-wrap; word-wrap: break-word;">Code looks good to me.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Regarding linter errors from https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-lint/49/console:</p><p style="white-space: pre-wrap; word-wrap: break-word;">1. firmware/libcommon/source/crcstub.c:31: WARNING:VOLATILE: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst</p><p style="white-space: pre-wrap; word-wrap: break-word;">Doesn't make sense here IMHO, submitted a patch to ignore it: https://gerrit.osmocom.org/c/osmo-ci/+/26464</p><p style="white-space: pre-wrap; word-wrap: break-word;">2. firmware/misc/crctool.c:77: WARNING:BRACES: braces {} are not necessary for single statement blocks</p><p style="white-space: pre-wrap; word-wrap: break-word;">Doesn't seem useful either: https://gerrit.osmocom.org/c/osmo-ci/+/26465</p><p style="white-space: pre-wrap; word-wrap: break-word;">3. firmware/libcommon/source/crcstub.c:16: ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Personally I like if there is not so much boilerplate at the start of every file, and having the mailing address from the FSF in there in 2021 is probably not useful. So I'd argue it makes sense to remove the address.</p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/26463">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile">File firmware/Makefile:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile@288">Patch Set #2, Line 288:</a> <code style="font-family:monospace,monospace">       m</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">a subsequent repeated 'make' command will no longer try executing crctool, as the .bin already exists?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">No, because "dfu" is a PHONY target.</p><p style="white-space: pre-wrap; word-wrap: break-word;">In case one would run the "dfu" target twice (although Eric says above that this usually is not done/possible?), it will attempt to run the crctool again and fail because the magic does not match anymore.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree that it would be cleaner to have it use a separate file, but it looks like this is not a problem.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/26463">change 26463</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/26463"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f </div>
<div style="display:none"> Gerrit-Change-Number: 26463 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 08 Dec 2021 11:16:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>