<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/26468">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bankd_pcsc: Don't log every successful SCardTransmit<br><br>Contrary to other operations, SCardTransmit has a much higher frequency<br>and the logs should not be clobbered with "OK" lines all over the place.<br><br>Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7<br>---<br>M src/bankd/bankd_pcsc.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c</span><br><span>index 5bc7bb8..91eeadd 100644</span><br><span>--- a/src/bankd/bankd_pcsc.c</span><br><span>+++ b/src/bankd/bankd_pcsc.c</span><br><span>@@ -297,9 +297,10 @@</span><br><span>         long rc;</span><br><span> </span><br><span>         rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, in_len);</span><br><span style="color: hsl(0, 100%, 40%);">-        PCSC_ERROR(worker, rc, "SCardTransmit");</span><br><span style="color: hsl(120, 100%, 40%);">+    /* don't use PCSC_ERROR here as we don't want to log every successful SCardTransmit */</span><br><span style="color: hsl(120, 100%, 40%);">+        if (rc != SCARD_S_SUCCESS)</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGW_PCSC_ERROR(worker, rc, "SCardTransmit");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-end:</span><br><span>      return rc;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/26468">change 26468</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/26468"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 </div>
<div style="display:none"> Gerrit-Change-Number: 26468 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>