<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/26430">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: checkpatch_osmo: ignore UNNECESSARY_BREAK<br><br>Not necessarily followed in Osmocom code, as Daniel wrote:<br>> The lint complains about this break, I don't agree with it though.<br>> Without we're one (or two) refactors away from an unintended<br>> fall-through<br><br>Related: OS#5087<br>Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e<br>---<br>M lint/checkpatch/checkpatch_osmo.sh<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/26430/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>index ec9384c..126a8b4 100755</span><br><span>--- a/lint/checkpatch/checkpatch_osmo.sh</span><br><span>+++ b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>@@ -70,6 +70,7 @@</span><br><span> # * SPLIT_STRING: we do split long messages over multiple lines</span><br><span> # * STRING_FRAGMENTS: sometimes used intentionally to improve readability</span><br><span> # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line</span><br><span style="color: hsl(120, 100%, 40%);">+# * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429)</span><br><span> # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345)</span><br><span> # * UNSPECIFIED_INT: not followed (doesn't seem useful for us)</span><br><span> </span><br><span>@@ -105,6 +106,7 @@</span><br><span>    --ignore SPLIT_STRING \</span><br><span>      --ignore STRING_FRAGMENTS \</span><br><span>  --ignore TRAILING_STATEMENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+        --ignore UNNECESSARY_BREAK \</span><br><span>         --ignore UNNECESSARY_INT \</span><br><span>   --ignore UNSPECIFIED_INT \</span><br><span>   --max-line-length 120 \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/26430">change 26430</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/26430"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e </div>
<div style="display:none"> Gerrit-Change-Number: 26430 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>