<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26421">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix assignment success counters: count *before* cleanup of fsm state<br><br>Counting the Assignment success after osmo_fsm_inst_term() meant that we<br>were counting a cleared out channel mode, which always yielded speech<br>mode.<br><br>Count the Assignment success *before* terminating, so that we correctly<br>count the successful assignment as speech mode.<br><br>Related: SYS#4878<br>Related: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 (osmo-ttcn3-hacks)<br>Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/26421/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index a3ec55b..0243058 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -295,10 +295,10 @@</span><br><span>                conn->user_plane.msc_assigned_rtp_port = conn->assignment.req.msc_rtp_port;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ assignment_count_result(CTR_ASSIGNMENT_COMPLETED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         LOG_ASSIGNMENT(conn, LOGL_DEBUG, "Assignment successful\n");</span><br><span>       osmo_fsm_inst_term(conn->assignment.fi, OSMO_FSM_TERM_REGULAR, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   assignment_count_result(CTR_ASSIGNMENT_COMPLETED);</span><br><span> }</span><br><span> </span><br><span> static void assignment_fsm_update_id(struct gsm_subscriber_connection *conn)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26421">change 26421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26421"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 </div>
<div style="display:none"> Gerrit-Change-Number: 26421 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>