<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26149">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess-config: improve readability of printed attribute response<br><br>Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876<br>---<br>M src/ipaccess/ipaccess-config.c<br>1 file changed, 18 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c</span><br><span>index 2d72d0e..c06a7cc 100644</span><br><span>--- a/src/ipaccess/ipaccess-config.c</span><br><span>+++ b/src/ipaccess/ipaccess-config.c</span><br><span>@@ -281,6 +281,7 @@</span><br><span>      char oml_ip[20] = {0};</span><br><span>       uint16_t oml_port = 0;</span><br><span>       char unit_id[40]  = {0};</span><br><span style="color: hsl(120, 100%, 40%);">+      unsigned int indent = 0;</span><br><span> </span><br><span> </span><br><span>     abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh));</span><br><span>@@ -290,8 +291,23 @@</span><br><span> </span><br><span>        abis_nm_tlv_attr_unit_id(&tp, unit_id,  sizeof(unit_id));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       fprintf(stdout, "{ \"primary_oml_ip\": \"%s\", \"primary_oml_port\": %" PRIu16 ", \"unit_id\": \"%s\" }\n",</span><br><span style="color: hsl(0, 100%, 40%);">-               oml_ip, oml_port, unit_id);</span><br><span style="color: hsl(120, 100%, 40%);">+#define ENDL(last) \</span><br><span style="color: hsl(120, 100%, 40%);">+     fprintf(stdout, "%s\n", last ? "" : ",")</span><br><span style="color: hsl(120, 100%, 40%);">+#define print_offset(fmt, args...) \</span><br><span style="color: hsl(120, 100%, 40%);">+  fprintf(stdout, "%*s" fmt, indent * 4, "", ## args)</span><br><span style="color: hsl(120, 100%, 40%);">+#define print_field(field, fmt, args...) \</span><br><span style="color: hsl(120, 100%, 40%);">+   print_offset("\"%s\": \"" fmt "\"", field, ## args)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ print_offset("{\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        indent++;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   print_field("primary_oml_ip", "%s", oml_ip); ENDL(false);</span><br><span style="color: hsl(120, 100%, 40%);">+ print_field("primary_oml_port", "%u", oml_port); ENDL(false);</span><br><span style="color: hsl(120, 100%, 40%);">+     print_field("unit_id", "%s", unit_id); ENDL(true);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      indent--;</span><br><span style="color: hsl(120, 100%, 40%);">+     print_offset("}\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26149">change 26149</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26149"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 </div>
<div style="display:none"> Gerrit-Change-Number: 26149 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: roox <mardnh@gmx.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>