<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26364">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Hoernchen: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Disable C/I based MS Power Control Loop by default<br><br>osmo-trx-uhd with a B200 has proven to provide bad (lower than usually<br>considered good) C/I values due to high noise (even with band filters in<br>place). Hence, default thresholds (gathered from literature on the topic)<br>are too high and end up in bad algorithm output decisions.<br>Furthermore, most users of Osmocom don't use it in densely populated<br>areas, hence RXLEV based algorithm used when C/I based one is disabled<br>is good enough.<br>Let's disable C/I based one by default, and let advanced users which<br>specific needs to enable and confiure thresholds specifically for their<br>needs (hardware, cell surrounding conditions, etc.).<br><br>Related: SYS#4917<br>Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279<br>---<br>M src/osmo-bsc/gsm_data.c<br>M tests/power_ctrl.vty<br>2 files changed, 38 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c</span><br><span>index 988d70e..38d8a7c 100644</span><br><span>--- a/src/osmo-bsc/gsm_data.c</span><br><span>+++ b/src/osmo-bsc/gsm_data.c</span><br><span>@@ -1200,7 +1200,7 @@</span><br><span> * above the target.</span><br><span> */</span><br><span> .ci_fr_meas = { /* FR: Target C/I = 15 dB, Soft blocking threshold = 10 dB */</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = true,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = false,</span><br><span> .lower_thresh = 13,</span><br><span> .upper_thresh = 17,</span><br><span> </span><br><span>@@ -1222,7 +1222,7 @@</span><br><span> .h_reqt = 6, /* TODO: investigate a reasonable default value */</span><br><span> },</span><br><span> .ci_hr_meas = { /* HR: Target C/I = 18 dB, Soft blocking threshold = 13 dB */</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = true,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = false,</span><br><span> .lower_thresh = 16,</span><br><span> .upper_thresh = 21,</span><br><span> </span><br><span>@@ -1244,7 +1244,7 @@</span><br><span> .h_reqt = 6, /* TODO: investigate a reasonable default value */</span><br><span> },</span><br><span> .ci_amr_fr_meas = { /* AMR-FR: Target C/I = 9 dB, Soft blocking threshold = 4 dB */</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = true,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = false,</span><br><span> .lower_thresh = 7,</span><br><span> .upper_thresh = 11,</span><br><span> </span><br><span>@@ -1266,7 +1266,7 @@</span><br><span> .h_reqt = 6, /* TODO: investigate a reasonable default value */</span><br><span> },</span><br><span> .ci_amr_hr_meas = { /* AMR-HR: Target C/I = 15 dB, Soft blocking threshold = 10 dB */</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = true,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = false,</span><br><span> .lower_thresh = 13,</span><br><span> .upper_thresh = 17,</span><br><span> </span><br><span>@@ -1288,7 +1288,7 @@</span><br><span> .h_reqt = 6, /* TODO: investigate a reasonable default value */</span><br><span> },</span><br><span> .ci_sdcch_meas = { /* SDCCH: Target C/I = 14 dB, Soft blocking threshold = 9 dB */</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = true,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = false,</span><br><span> .lower_thresh = 12,</span><br><span> .upper_thresh = 16,</span><br><span> </span><br><span>@@ -1310,7 +1310,7 @@</span><br><span> .h_reqt = 6, /* TODO: investigate a reasonable default value */</span><br><span> },</span><br><span> .ci_gprs_meas = { /* GPRS: Target C/I = 20 dB, Soft blocking threshold = 15 dB */</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = true,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = false,</span><br><span> .lower_thresh = 18,</span><br><span> .upper_thresh = 24,</span><br><span> </span><br><span>diff --git a/tests/power_ctrl.vty b/tests/power_ctrl.vty</span><br><span>index 374002d..f0ef46e 100644</span><br><span>--- a/tests/power_ctrl.vty</span><br><span>+++ b/tests/power_ctrl.vty</span><br><span>@@ -143,22 +143,22 @@</span><br><span> rxlev-thresh-comp lower 10 12 upper 19 20</span><br><span> rxqual-thresh lower 3 upper 0</span><br><span> rxqual-thresh-comp lower 5 7 upper 15 18</span><br><span style="color: hsl(0, 100%, 40%);">- ci-thresh fr-efr enable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh fr-efr disable</span><br><span> ci-thresh fr-efr lower 13 upper 17</span><br><span> ci-thresh-comp fr-efr lower 5 7 upper 15 18</span><br><span style="color: hsl(0, 100%, 40%);">- ci-thresh hr enable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh hr disable</span><br><span> ci-thresh hr lower 16 upper 21</span><br><span> ci-thresh-comp hr lower 5 7 upper 15 18</span><br><span style="color: hsl(0, 100%, 40%);">- ci-thresh amr-fr enable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh amr-fr disable</span><br><span> ci-thresh amr-fr lower 7 upper 11</span><br><span> ci-thresh-comp amr-fr lower 5 7 upper 15 18</span><br><span style="color: hsl(0, 100%, 40%);">- ci-thresh amr-hr enable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh amr-hr disable</span><br><span> ci-thresh amr-hr lower 13 upper 17</span><br><span> ci-thresh-comp amr-hr lower 5 7 upper 15 18</span><br><span style="color: hsl(0, 100%, 40%);">- ci-thresh sdcch enable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh sdcch disable</span><br><span> ci-thresh sdcch lower 12 upper 16</span><br><span> ci-thresh-comp sdcch lower 5 7 upper 15 18</span><br><span style="color: hsl(0, 100%, 40%);">- ci-thresh gprs enable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh gprs disable</span><br><span> ci-thresh gprs lower 18 upper 24</span><br><span> ci-thresh-comp gprs lower 5 7 upper 15 18</span><br><span> ...</span><br><span>@@ -304,12 +304,37 @@</span><br><span> rxqual-thresh-comp lower 5 7 upper 15 18</span><br><span> ...</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# ### Check 'ci-thresh-comp disable all' works properly:</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# ### Check 'ci-thresh-comp (enable|disable) all' works properly:</span><br><span> OsmoBSC(config-net-bts)# ms-power-control</span><br><span> OsmoBSC(config-ms-power-ctrl)# show running-config</span><br><span> ...</span><br><span> ms-power-control</span><br><span> ...</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh fr-efr disable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh fr-efr lower 13 upper 17</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh-comp fr-efr lower 5 7 upper 15 18</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh hr disable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh hr lower 16 upper 21</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh-comp hr lower 5 7 upper 15 18</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh amr-fr disable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh amr-fr lower 7 upper 11</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh-comp amr-fr lower 5 7 upper 15 18</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh amr-hr disable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh amr-hr lower 13 upper 17</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh-comp amr-hr lower 5 7 upper 15 18</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh sdcch disable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh sdcch lower 12 upper 16</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh-comp sdcch lower 5 7 upper 15 18</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh gprs disable</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh gprs lower 18 upper 24</span><br><span style="color: hsl(120, 100%, 40%);">+ ci-thresh-comp gprs lower 5 7 upper 15 18</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-ms-power-ctrl)# ci-thresh all enable</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-ms-power-ctrl)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ ms-power-control</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span> ci-thresh fr-efr enable</span><br><span> ci-thresh fr-efr lower 13 upper 17</span><br><span> ci-thresh-comp fr-efr lower 5 7 upper 15 18</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26364">change 26364</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26364"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 </div>
<div style="display:none"> Gerrit-Change-Number: 26364 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>