<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/26360">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: Fix memory leak in case async log write queue overflows<br><br>In case osmo_wqueue_enqueue_quiet() fails, msgb ownership is not<br>transferred to the queue, but the caller is responsible for freeing<br>the message buffer that we just failed to enqueue.<br><br>Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810<br>Closes: OS#5328<br>Related: OS#5329<br>---<br>M src/logging.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/26360/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index 9e2f5c2..b6c26d2 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -992,7 +992,10 @@</span><br><span>      }</span><br><span>    /* if we reach here, either we already had elements in the write_queue, or the synchronous write</span><br><span>      * failed: enqueue the message to the write_queue (backlog) */</span><br><span style="color: hsl(0, 100%, 40%);">-  osmo_wqueue_enqueue_quiet(target->tgt_file.wqueue, msg);</span><br><span style="color: hsl(120, 100%, 40%);">+   if (osmo_wqueue_enqueue_quiet(target->tgt_file.wqueue, msg) < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+               /* TODO: increment some counter so we can see that messages were dropped */</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/26360">change 26360</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/26360"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 </div>
<div style="display:none"> Gerrit-Change-Number: 26360 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>