<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/26355">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cbch: Fix bts_smscb_state_reset() to avoid double-free<br><br>If the currently transmitted message is the default message,<br>bts_ss->cur_msg == bts_ss->derfault_msg.  In this case we cannot<br>simply talloc_free() both of them, as it would result in a boudle-free.<br><br>Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808<br>Closes: OS#5325<br>Fixes: Ib01d38c59ba9fa083fcc0682009c13d2db3664fe<br>---<br>M src/common/cbch.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/cbch.c b/src/common/cbch.c</span><br><span>index addd68c..a3e1296 100644</span><br><span>--- a/src/common/cbch.c</span><br><span>+++ b/src/common/cbch.c</span><br><span>@@ -332,7 +332,10 @@</span><br><span>        }</span><br><span>    bts_ss->queue_len = 0;</span><br><span>    rate_ctr_group_reset(bts_ss->ctrs);</span><br><span style="color: hsl(0, 100%, 40%);">-  TALLOC_FREE(bts_ss->cur_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+      /* avoid double-free of default_msg in case cur_msg == default_msg */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts_ss->cur_msg && bts_ss->cur_msg != bts_ss->default_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+               talloc_free(bts_ss->cur_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+      bts_ss->cur_msg = NULL;</span><br><span>   TALLOC_FREE(bts_ss->default_msg);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/26355">change 26355</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/26355"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 </div>
<div style="display:none"> Gerrit-Change-Number: 26355 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>