<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/25873">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cards: Make select_adf_by_aid() use prefix AID selection<br><br>There is no need for us to expand a partial AID to the full AID before<br>selecting that ADF. The UICC specifications permit AID selection by<br>prefix only. So we could pass the prefix to the card, and the card would<br>do the prefix matching. In order to avoid problems with cards that fail<br>to do the prefix matching themselves we will still do the AID<br>completion, but in case we cannot complete the AID (AID not listed in<br>EF.DIR), we will try with the AID prefix anyway.<br><br>From the API user point of view, this allows us to select applications<br>not listed in EF.DIR<br><br>Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317<br>---<br>M pySim/cards.py<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index a822161..45e44a2 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -308,6 +308,9 @@</span><br><span>                       aid_full = self._complete_aid(aid)</span><br><span>                   if aid_full:</span><br><span>                                 return self._scc.select_adf(aid_full)</span><br><span style="color: hsl(120, 100%, 40%);">+                 else:</span><br><span style="color: hsl(120, 100%, 40%);">+                         # If we cannot get the full AID, try with short AID</span><br><span style="color: hsl(120, 100%, 40%);">+                           return self._scc.select_adf(aid)</span><br><span>             return (None, None)</span><br><span> </span><br><span>      def erase_binary(self, ef):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/25873">change 25873</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/25873"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 </div>
<div style="display:none"> Gerrit-Change-Number: 25873 </div>
<div style="display:none"> Gerrit-PatchSet: 12 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Assignee: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>