<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: show bug: do inter-BSC-out HO by measurement report<br><br>So far all handover tests trigger handover via VTY command. This means<br>that any bugs introduced in measurement report handling and handover<br>target selection are by definition not caught.<br><br>Almost a year ago, fixing a handover oscillation bug for intra-BSC<br>handover introduced a segfault for inter-BSC handover targets, because<br>for those the target.bts is NULL. Show this bug.<br><br>Related: OS#5324 SYS#5259<br>Related: I5a3345ab0005a73597f5c27207480912a2f5aae6 (osmo-bsc)<br>Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d<br>---<br>M bsc/BSC_Tests.ttcn<br>M library/RSL_Types.ttcn<br>2 files changed, 60 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 1f4a615..b34ad29 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -5384,8 +5384,12 @@</span><br><span> </span><br><span> private function f_ho_out_of_this_bsc(template (omit) BSSMAP_oldToNewBSSIEs exp_oldToNewBSSIEs := omit) runs on MSC_ConnHdlr {</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(0, 100%, 40%);">- f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any");</span><br><span style="color: hsl(120, 100%, 40%);">+ var NcellReports neighbor_rep := {</span><br><span style="color: hsl(120, 100%, 40%);">+ { rxlev := 20, bcch_freq := 0, bsic := 11 }</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring l3_mr := enc_GsmRrL3Message(valueof(ts_MEAS_REP(true, 8, 8, reps := neighbor_rep)));</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.send(ts_RSL_MEAS_RES(g_chan_nr, 0, ts_RSL_IE_UplinkMeas, ts_RSL_IE_BS_Power(0), ts_RSL_IE_L1Info,</span><br><span style="color: hsl(120, 100%, 40%);">+ l3_mr, 0));</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequired(exp_oldToNewBSSIEs));</span><br><span> </span><br><span>@@ -5450,6 +5454,15 @@</span><br><span> testcase TC_ho_out_of_this_bsc() runs on test_CT {</span><br><span> var MSC_ConnHdlr vc_conn;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_vty();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bts_0_cfg(BSCVTY,</span><br><span style="color: hsl(120, 100%, 40%);">+ {"neighbor-list mode automatic",</span><br><span style="color: hsl(120, 100%, 40%);">+ "handover 1",</span><br><span style="color: hsl(120, 100%, 40%);">+ "handover algorithm 2",</span><br><span style="color: hsl(120, 100%, 40%);">+ "handover2 window rxlev averaging 1",</span><br><span style="color: hsl(120, 100%, 40%);">+ "neighbor lac 99 arfcn 123 bsic any"});</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(BSCVTY, "drop bts connection 0 oml");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> f_init(1, true);</span><br><span> f_sleep(1.0);</span><br><span> </span><br><span>@@ -10831,7 +10844,7 @@</span><br><span> execute( TC_ho_int_a5_4() );</span><br><span> execute( TC_ho_int_radio_link_failure() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- execute( TC_ho_out_of_this_bsc() );</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TC_ho_out_of_this_bsc is run last, see comment below */</span><br><span> execute( TC_ho_out_fail_no_msc_response() );</span><br><span> execute( TC_ho_out_fail_rr_ho_failure() );</span><br><span> execute( TC_ho_out_fail_no_result_after_ho_cmd() );</span><br><span>@@ -10954,6 +10967,10 @@</span><br><span> execute( TC_cm_serv_rej() );</span><br><span> </span><br><span> execute( TC_lost_sdcch_during_assignment() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Run TC_ho_out_of_this_bsc last, because it may trigger a segfault before osmo-bsc's patch</span><br><span style="color: hsl(120, 100%, 40%);">+ * with change-id I5a3345ab0005a73597f5c27207480912a2f5aae6 */</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_ho_out_of_this_bsc() );</span><br><span> }</span><br><span> </span><br><span> }</span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index 1057f0b..70fb398 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -508,6 +508,13 @@</span><br><span> uint8_t actual_ta</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_L1Info ts_RSL_IE_L1Info := {</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_power_lvl := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ fpc := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ reserved := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ actual_ta := 0</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 9.3.13 */</span><br><span> type record RSL_IE_MS_Power {</span><br><span> uint2_t reserved,</span><br><span>@@ -632,6 +639,19 @@</span><br><span> RSL_IE_UplinkMeasSuppMeasInfo supp_meas_info optional</span><br><span> } with { variant (len) "LENGTHTO(rfu,dtx_d,rxlev_f_u,reserved1,rxlev_s_u,reserved2,rxq_f_u,rxq_s_u,supp_meas_info)" };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_UplinkMeas ts_RSL_IE_UplinkMeas(uint6_t rxlev := 12, uint3_t rxqual := 0) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ len := 0, /* overwritten */</span><br><span style="color: hsl(120, 100%, 40%);">+ rfu := '0'B,</span><br><span style="color: hsl(120, 100%, 40%);">+ dtx_d := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ rxlev_f_u := rxlev,</span><br><span style="color: hsl(120, 100%, 40%);">+ reserved1 := '00'B,</span><br><span style="color: hsl(120, 100%, 40%);">+ rxlev_s_u := rxlev,</span><br><span style="color: hsl(120, 100%, 40%);">+ reserved2 := '00'B,</span><br><span style="color: hsl(120, 100%, 40%);">+ rxq_f_u := rxqual,</span><br><span style="color: hsl(120, 100%, 40%);">+ rxq_s_u := rxqual,</span><br><span style="color: hsl(120, 100%, 40%);">+ supp_meas_info := omit</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 9.3.26 */</span><br><span> type enumerated RSL_Cause {</span><br><span> /* normal event */</span><br><span>@@ -1549,6 +1569,26 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_Message ts_RSL_MEAS_RES(template (value) RslChannelNr chan_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t meas_res_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_UplinkMeas ul_meas,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_BS_Power bs_power,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_L1Info l1_info,</span><br><span style="color: hsl(120, 100%, 40%);">+ octetstring l3_info,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t ms_to) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false),</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_type := RSL_MT_MEAS_RES,</span><br><span style="color: hsl(120, 100%, 40%);">+ ies := {</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_MEAS_RES_NR, RSL_IE_Body:{meas_res_nr := meas_res_nr}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_UPLINK_MEAS, RSL_IE_Body:{uplink_meas := ul_meas}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_BS_POWER, RSL_IE_Body:{bs_power := bs_power}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_L1_INFO, RSL_IE_Body:{l1_info := l1_info}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_L3_INFO, RSL_IE_Body:{l3_info := ts_RSL_L16V(l3_info)}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_MS_TIMING_OFFSET, RSL_IE_Body:{ms_timing_offset := ms_to})</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 8.4.9 BSC -> BTS */</span><br><span> template (value) RSL_Message ts_RSL_MODE_MODIFY_REQ(template (value) RslChannelNr chan_nr,</span><br><span> template (value) RSL_IE_ChannelMode mode) := {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354">change 26354</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d </div>
<div style="display:none"> Gerrit-Change-Number: 26354 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>