<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26350">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc_subscr_conn_fsm: fix crash if !conn<br><br>Do not crash in gscon_ensure_mgw_endpoint() if conn is NULL. Such checks<br>are also in gscon_is_sccplite() and gscon_is_aoip() already, so it will<br>end up in the return NULL codepath.<br><br>Related: SYS#5728<br>Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/26350/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index c18079f..f549ee1 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -521,7 +521,7 @@</span><br><span>  const char *epname;</span><br><span>  struct mgcp_client *mgcp_client = NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (conn->user_plane.mgw_endpoint)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (conn && conn->user_plane.mgw_endpoint)</span><br><span>                return conn->user_plane.mgw_endpoint;</span><br><span> </span><br><span>         if (gscon_is_sccplite(conn) || gscon_is_aoip(conn)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26350">change 26350</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26350"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf </div>
<div style="display:none"> Gerrit-Change-Number: 26350 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>