<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Also try to route STATUS messages with truncated PDU in error<br><br>Related: OS#4892<br>Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873<br>---<br>M src/gb_proxy.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index 6fd6f77..fbb6e79 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -982,9 +982,9 @@</span><br><span>         struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data;</span><br><span>         struct tlv_parsed tp_inner;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: Parse partial messages as well */</span><br><span>   rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx);</span><br><span style="color: hsl(0, 100%, 40%);">-       if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Ignore decode failure due to truncated message */</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc < 0 && rc != OSMO_TLVP_ERR_OFS_BEYOND_BUFFER)</span><br><span>              return rc;</span><br><span> </span><br><span>       if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TLLI)) {</span><br><span>@@ -1010,9 +1010,9 @@</span><br><span>    struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data;</span><br><span>         struct tlv_parsed tp_inner;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: Parse partial messages as well */</span><br><span>   rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx);</span><br><span style="color: hsl(0, 100%, 40%);">-       if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Ignore decode failure due to truncated message */</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc < 0 && rc != OSMO_TLVP_ERR_OFS_BEYOND_BUFFER)</span><br><span>              return rc;</span><br><span> </span><br><span>       if (TLVP_PRESENT(&tp_inner, BSSGP_IE_BVCI))</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319">change 26319</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 </div>
<div style="display:none"> Gerrit-Change-Number: 26319 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>