<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  dexter: Looks good to me, approved
  fixeria: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">protocol: fix: properly declare value_string arrays<br><br>Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef<br>---<br>M src/protocol/diag_log_gprs_l1.h<br>M src/protocol/diag_log_gsm.h<br>2 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h</span><br><span>index eee9632..8f8585c 100644</span><br><span>--- a/src/protocol/diag_log_gprs_l1.h</span><br><span>+++ b/src/protocol/diag_log_gprs_l1.h</span><br><span>@@ -72,7 +72,7 @@</span><br><span>   DIAG_TX_UL_CH_T_UL_PTCCH,</span><br><span>    DIAG_TX_UL_CH_T_UL_PACCH_PDTCH,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string gprs_tx_ul_chans[4];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string gprs_tx_ul_chans[4];</span><br><span> </span><br><span> enum gprs_coding_scheme {</span><br><span>  DIAG_GPRS_CS_CS1,</span><br><span>@@ -91,7 +91,7 @@</span><br><span>        DIAG_GPRS_CS_MCS8,</span><br><span>   DIAG_GPRS_CS_MCS9,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string gprs_coding_schemes[16];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string gprs_coding_schemes[16];</span><br><span> </span><br><span> struct gprs_tx_sched_res {</span><br><span>      uint32_t        fn;</span><br><span>diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h</span><br><span>index 378472f..d382f1a 100644</span><br><span>--- a/src/protocol/diag_log_gsm.h</span><br><span>+++ b/src/protocol/diag_log_gsm.h</span><br><span>@@ -192,7 +192,7 @@</span><br><span>   DIAG_GPRS_LLMES_TLLI_ASS        = 1,</span><br><span>         DIAG_GPRS_LLMES_TEST_MODE       = 2,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string diag_gprs_llme_st_vals[4];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gprs_llme_st_vals[4];</span><br><span> </span><br><span> /* LOG_GPRS_LLC_ME_INFO_C */</span><br><span> struct diag_gprs_llme_info {</span><br><span>@@ -282,7 +282,7 @@</span><br><span>        DIAG_SAPI0_ST_LINK_SUSP,</span><br><span>     DIAG_SAPI0_ST_UA_PEND,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string diag_gsm_l2_sapi0_st_vals[10];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gsm_l2_sapi0_st_vals[10];</span><br><span> </span><br><span> enum diag_gsm_sapi3_state {</span><br><span>     DIAG_SAPI3_ST_NULL,</span><br><span>@@ -294,7 +294,7 @@</span><br><span>    DIAG_SAPI3_ST_TMR_RECOV,</span><br><span>     DIAG_SAPI3_ST_UA_PEND,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string diag_gsm_l2_sapi3_st_vals[9];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gsm_l2_sapi3_st_vals[9];</span><br><span> </span><br><span> enum diag_gsm_l2_event {</span><br><span>  DIAG_L2_EV_NO_EVENT,</span><br><span>@@ -325,7 +325,7 @@</span><br><span>   DIAG_L2_EV_UA_SENT,</span><br><span>  DIAG_L2_EV_FORCED_SUSPEND_REQ,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string diag_gsm_l2_event_vals[28];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gsm_l2_event_vals[28];</span><br><span> </span><br><span> struct diag_gsm_l2_state {</span><br><span>    uint8_t sapi;</span><br><span>@@ -343,7 +343,7 @@</span><br><span>  DIAG_L2_CHT_FACCH_F     = 6,</span><br><span>         DIAG_L2_CHT_FACCH_H     = 7,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string diag_gsm_l2_chantype_vals[9];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gsm_l2_chantype_vals[9];</span><br><span> </span><br><span> struct diag_gsm_l2_transm_status {</span><br><span>  uint8_t sapi;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326">change 26326</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-qcdiag </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef </div>
<div style="display:none"> Gerrit-Change-Number: 26326 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>