<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">const struct value_string *[]: remove static array size<br><br>Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900<br>---<br>M src/gprs_l1.c<br>M src/gprs_rlc.c<br>M src/protocol/diag_log_gprs_l1.h<br>M src/protocol/diag_log_gprs_mac.h<br>M src/protocol/diag_log_gprs_rlc.h<br>M src/protocol/diag_log_gsm.h<br>6 files changed, 20 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-qcdiag refs/changes/32/26332/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_l1.c b/src/gprs_l1.c</span><br><span>index d830e60..d00bf5b 100644</span><br><span>--- a/src/gprs_l1.c</span><br><span>+++ b/src/gprs_l1.c</span><br><span>@@ -20,14 +20,14 @@</span><br><span> </span><br><span> #include "protocol/diag_log_gprs_l1.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string gprs_tx_ul_chans[4] = {</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string gprs_tx_ul_chans[] = {</span><br><span>         { DIAG_TX_UL_CH_T_PRACH,        "PRACK" },</span><br><span>         { DIAG_TX_UL_CH_T_UL_PTCCH,     "UL-PTCCH" },</span><br><span>      { DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, "UL-PACCH-PDTCH" },</span><br><span>      { 0, NULL }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string gprs_coding_schemes[16] = {</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string gprs_coding_schemes[] = {</span><br><span>      { DIAG_GPRS_CS_CS1,     "CS1" },</span><br><span>   { DIAG_GPRS_CS_CS2,     "CS2" },</span><br><span>   { DIAG_GPRS_CS_CS3,     "CS3" },</span><br><span>diff --git a/src/gprs_rlc.c b/src/gprs_rlc.c</span><br><span>index be01a53..1b46c83 100644</span><br><span>--- a/src/gprs_rlc.c</span><br><span>+++ b/src/gprs_rlc.c</span><br><span>@@ -20,7 +20,7 @@</span><br><span> </span><br><span> #include "protocol/diag_log_gprs_rlc.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct value_string gprs_rlc_ul_state_vals[8] = {</span><br><span style="color: hsl(120, 100%, 40%);">+struct value_string gprs_rlc_ul_state_vals[] = {</span><br><span>  { US_NULL,              "US_NULL" },</span><br><span>       { US_AWAIT_ASS,         "US_AWAIT_ASS" },</span><br><span>  { US_ACK_XFER,          "US_AWAIT_XFER" },</span><br><span>@@ -31,7 +31,7 @@</span><br><span>     { 0, NULL }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct value_string gprs_rlc_ul_substate_vals[5] = {</span><br><span style="color: hsl(120, 100%, 40%);">+struct value_string gprs_rlc_ul_substate_vals[] = {</span><br><span>       { RALS_NULL,            "RALS_NULL" },</span><br><span>     { RALS_AWAIT_TX_COMPLETE, "RALS_AWAIT_TX_COMPLETE" },</span><br><span>      { RALS_CURRENT_PDU_TX_COMPLETED, "RALS_CURRENT_PDU_TX_COMPLETED" },</span><br><span>@@ -39,7 +39,7 @@</span><br><span>    { 0, NULL }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct value_string gprs_rlc_dl_state_vals[7] = {</span><br><span style="color: hsl(120, 100%, 40%);">+struct value_string gprs_rlc_dl_state_vals[] = {</span><br><span>     { DS_NULL,              "DS_NULL" },</span><br><span>       { DS_RX_ACK,            "DS_RX_ACK" },</span><br><span>     { DS_RX_UNACK,          "DS_RX_UNACK" },</span><br><span>diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h</span><br><span>index 8f8585c..995eff2 100644</span><br><span>--- a/src/protocol/diag_log_gprs_l1.h</span><br><span>+++ b/src/protocol/diag_log_gprs_l1.h</span><br><span>@@ -72,7 +72,7 @@</span><br><span>      DIAG_TX_UL_CH_T_UL_PTCCH,</span><br><span>    DIAG_TX_UL_CH_T_UL_PACCH_PDTCH,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern const struct value_string gprs_tx_ul_chans[4];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string gprs_tx_ul_chans[];</span><br><span> </span><br><span> enum gprs_coding_scheme {</span><br><span>    DIAG_GPRS_CS_CS1,</span><br><span>@@ -91,7 +91,7 @@</span><br><span>        DIAG_GPRS_CS_MCS8,</span><br><span>   DIAG_GPRS_CS_MCS9,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern const struct value_string gprs_coding_schemes[16];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string gprs_coding_schemes[];</span><br><span> </span><br><span> struct gprs_tx_sched_res {</span><br><span>         uint32_t        fn;</span><br><span>diff --git a/src/protocol/diag_log_gprs_mac.h b/src/protocol/diag_log_gprs_mac.h</span><br><span>index 536128d..16122ae 100644</span><br><span>--- a/src/protocol/diag_log_gprs_mac.h</span><br><span>+++ b/src/protocol/diag_log_gprs_mac.h</span><br><span>@@ -7,7 +7,7 @@</span><br><span>   IDLE_MODE,</span><br><span>   TRANSFER_MODE,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_mac_mode_vals[4];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_mac_mode_vals[];</span><br><span> </span><br><span> enum gprs_mac_null_substates {</span><br><span>        NULL_INACTIVE,</span><br><span>@@ -23,7 +23,7 @@</span><br><span>   NULL_DTM_GTTP_UL_CON,</span><br><span>        NULL_RESET,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_mac_null_substate_vals[13];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_mac_null_substate_vals[];</span><br><span> </span><br><span> enum gprs_mac_idle_substates {</span><br><span>        IDLE_PASSIVE,</span><br><span>@@ -35,7 +35,7 @@</span><br><span>    IDLE_UL_1PHASE_CONT_RES,</span><br><span>     IDLE_DL_ASS,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_mac_idle_substate_vals[9];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_mac_idle_substate_vals[];</span><br><span> </span><br><span> enum gprs_mac_transfer_substates {</span><br><span>    TRANSFER_INACTIVE,</span><br><span>@@ -52,7 +52,7 @@</span><br><span>       TRANSFER_CONCURRENT_DYNAMIC_REALLOC,</span><br><span>         TRANSFER_CONCURRENT_DL_REASSIGN_DYNAMIC_REALLOC,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_mac_transfer_substate_vals[14];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_mac_transfer_substate_vals[];</span><br><span> </span><br><span> /* LOG_GPRS_MAC_STATE_C */</span><br><span> struct gprs_mac_state_change {</span><br><span>@@ -126,7 +126,7 @@</span><br><span>       PBCCH_CHANNEL           = 0x82,</span><br><span>      DL_PACCH_CHANNEL        = 0x83,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_mac_chan_type_vals[8];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_mac_chan_type_vals[];</span><br><span> </span><br><span> enum gprs_mac_msg_type {</span><br><span>   PACKET_CELL_CHANGE_FAILURE              = 0x00,</span><br><span>@@ -146,7 +146,7 @@</span><br><span>        PACKET_CS_REQUEST                       = 0x0e,</span><br><span>      PACKET_CHANNEL_REQUEST                  = 0x20,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_mac_msg_type_vals[17];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_mac_msg_type_vals[];</span><br><span> </span><br><span> struct evt_gprs_mac_msg {</span><br><span>   uint8_t msg_type;</span><br><span>diff --git a/src/protocol/diag_log_gprs_rlc.h b/src/protocol/diag_log_gprs_rlc.h</span><br><span>index f59c662..49f1b2c 100644</span><br><span>--- a/src/protocol/diag_log_gprs_rlc.h</span><br><span>+++ b/src/protocol/diag_log_gprs_rlc.h</span><br><span>@@ -28,7 +28,7 @@</span><br><span>   US_TEST_MODE,</span><br><span>        US_AWAIT_RECOVERY,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_rlc_ul_state_vals[8];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_rlc_ul_state_vals[];</span><br><span> </span><br><span> enum gprs_rlc_ul_substate {</span><br><span>       RALS_NULL,</span><br><span>@@ -36,7 +36,7 @@</span><br><span>       RALS_CURRENT_PDU_TX_COMPLETED,</span><br><span>       RALS_COMPLETE,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_rlc_ul_substate_vals[5];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_rlc_ul_substate_vals[];</span><br><span> </span><br><span> enum gprs_rlc_dl_state {</span><br><span>        DS_NULL,</span><br><span>@@ -46,7 +46,7 @@</span><br><span>         DS_RX_UNACK_PENDING_RELEASE,</span><br><span>         DS_TEST_MODE,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_rlc_dl_state_vals[7];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_rlc_dl_state_vals[];</span><br><span> </span><br><span> /* LOG_GPRS_RLC_UL_STATS_C */</span><br><span> struct gprs_rlc_ul_stats {</span><br><span>@@ -125,7 +125,7 @@</span><br><span>      EGPRS_HEADER_TYPE_2,</span><br><span>         EGPRS_HEADER_TYPE_3</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern struct value_string gprs_rlc_hdr_type_vals[5];</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct value_string gprs_rlc_hdr_type_vals[];</span><br><span> </span><br><span> </span><br><span> /* LOG_EGPRS_RLC_DL_HEADER_C */</span><br><span>diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h</span><br><span>index d382f1a..5d956b4 100644</span><br><span>--- a/src/protocol/diag_log_gsm.h</span><br><span>+++ b/src/protocol/diag_log_gsm.h</span><br><span>@@ -158,7 +158,7 @@</span><br><span>       DIAG_RR_ST_RESET                = 23,</span><br><span>        DIAG_RR_ST_W2G_BACKGROUND_PLN_SEARCH = 24,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern const struct value_string diag_gsm_rr_st_vals[25];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gsm_rr_st_vals[];</span><br><span> </span><br><span> /* LOG_GSM_RR_STATE_C */</span><br><span> struct diag_gsm_rr_state {</span><br><span>@@ -178,7 +178,7 @@</span><br><span>       DIAG_GRR_ST_BG_PLMN_SEARCH      = 7,</span><br><span>         DIAG_GRR_ST_PCCO        = 8,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern const struct value_string diag_gprs_grr_st_vals[9];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gprs_grr_st_vals[];</span><br><span> </span><br><span> /* LOG_GPRS_GRR_STATE_C */</span><br><span> struct diag_gprs_grr_state {</span><br><span>@@ -192,7 +192,7 @@</span><br><span>      DIAG_GPRS_LLMES_TLLI_ASS        = 1,</span><br><span>         DIAG_GPRS_LLMES_TEST_MODE       = 2,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-extern const struct value_string diag_gprs_llme_st_vals[4];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string diag_gprs_llme_st_vals[];</span><br><span> </span><br><span> /* LOG_GPRS_LLC_ME_INFO_C */</span><br><span> struct diag_gprs_llme_info {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332">change 26332</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-qcdiag </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 </div>
<div style="display:none"> Gerrit-Change-Number: 26332 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>