<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Fix error return value<br><br>OSMO_TLVP_ERR_MAND_IE_MISSING is already negative<br><br>Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb<br>---<br>M src/gb_proxy.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/18/26318/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index 3d76a33..6fd6f77 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -388,7 +388,7 @@</span><br><span>      if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA || bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) {</span><br><span>            const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) bgph;</span><br><span>              if (msg_len < sizeof(*budh))</span><br><span style="color: hsl(0, 100%, 40%);">-                 return -OSMO_TLVP_ERR_MAND_IE_MISSING;</span><br><span style="color: hsl(120, 100%, 40%);">+                        return OSMO_TLVP_ERR_MAND_IE_MISSING;</span><br><span>                rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, budh->pdu_type, budh->data,</span><br><span>                                       msg_len - sizeof(*budh), 0, 0, DGPRS, log_pfx);</span><br><span>             /* populate TLLI from the fixed headser into the TLV-parsed array so later code</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318">change 26318</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb </div>
<div style="display:none"> Gerrit-Change-Number: 26318 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>