<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26192">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix mgcp_conn_free_all ubsan complaints<br><br>ubsan still complains about a unaligned load that can't be explained, so<br>silence it:<br><br>/mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime<br>error: member access within misaligned address 0x612000000249 for type<br>'const struct llist_head', which requires 8 byte alignment<br>0x612000000249: note: pointer points here<br>00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00<br>a0 62 00 00 80 1f 49 00 00<br> ^<br>SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior<br>/mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in<br>/mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime<br>error: load of misaligned address 0x612000000249 for type 'struct<br>llist_head *const', which requires 8 byte alignment<br>0x612000000249: note: pointer points here<br>00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00<br>a0 62 00 00 80 1f 49 00 00<br> ^<br>SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior<br>/mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in<br>mgcp_conn.c:303:17: runtime error: member access within misaligned<br>address 0x612000000249 for type 'struct llist_head', which requires 8<br>byte alignment<br>0x612000000249: note: pointer points here<br>00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00<br>a0 62 00 00 80 1f 49 00 00<br> ^<br>SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior<br>mgcp_conn.c:303:17 in<br>mgcp_conn.c:303:17: runtime error: load of misaligned address<br>0x612000000249 for type 'struct llist_head *', which requires 8 byte<br>alignment<br>0x612000000249: note: pointer points here<br>00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00<br>a0 62 00 00 80 1f 49 00 00<br> ^<br>SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior<br>mgcp_conn.c:303:17 in<br>mgcp_conn.c:304:30: runtime error: member access within misaligned<br>address 0x4800006120000002 for type 'struct mgcp_conn', which requires 8<br>byte alignment<br>0x4800006120000002: note: pointer points here<br><memory cannot be printed><br>SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior<br>mgcp_conn.c:304:30 in<br>AddressSanitizer:DEADLYSIGNAL<br>=================================================================<br>==223426==ERROR: AddressSanitizer: SEGV on unknown address (pc<br>0x0000004553f7 bp 0x7ffda5855080 sp 0x7ffda5855040 T0)<br>==223426==The signal is caused by a READ memory access.<br>==223426==Hint: this fault was caused by a dereference of a high value<br>address (see register values below). Disassemble the provided pc to<br>learn which register was used.<br>/mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14<br>/mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:258:9<br>/mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:304:3<br>/mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_endp.c:124:2<br>/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:670:3<br>/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:923:2<br>/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:2248:2<br>/build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16<br>(/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test+0x404c2d)<br><br>AddressSanitizer can not provide additional info.<br>SUMMARY: AddressSanitizer: SEGV<br>/mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 in<br>mgcp_conn_get<br>==223426==ABORTING<br><br>Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb<br>---<br>M src/libosmo-mgcp/mgcp_conn.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c</span><br><span>index 4f6e1a2..5c3c60e 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_conn.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_conn.c</span><br><span>@@ -325,6 +325,11 @@</span><br><span> </span><br><span> /*! free all connections at once.</span><br><span> * \param[in] endp associated endpoint */</span><br><span style="color: hsl(120, 100%, 40%);">+#if defined(__has_attribute)</span><br><span style="color: hsl(120, 100%, 40%);">+#if __has_attribute(no_sanitize)</span><br><span style="color: hsl(120, 100%, 40%);">+__attribute__((no_sanitize("undefined"))) /* ubsan detects a misaligned load */</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> void mgcp_conn_free_all(struct mgcp_endpoint *endp)</span><br><span> {</span><br><span> struct mgcp_conn *conn;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26192">change 26192</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/26192"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb </div>
<div style="display:none"> Gerrit-Change-Number: 26192 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>