<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcap/+/26266">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Explicitly depend on required libosmogb<br><br>the spec.in files already stated so expicitly, since some files include<br>osmocom/gprs/*.h. Only some data types from there are used, so there's<br>no need in linking the lib. Even more, doing so makes the build fail<br>because there soft-linking symbols required to be implemented by<br>libosmogb are not implemented here.<br><br>Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989<br>---<br>M configure.ac<br>M src/Makefile.am<br>2 files changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/66/26266/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configure.ac b/configure.ac</span><br><span>index f4c004a..7856522 100644</span><br><span>--- a/configure.ac</span><br><span>+++ b/configure.ac</span><br><span>@@ -158,6 +158,7 @@</span><br><span> </span><br><span> dnl checks for libraries</span><br><span> PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0)</span><br><span style="color: hsl(120, 100%, 40%);">+PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0)</span><br><span> PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0)</span><br><span> PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0)</span><br><span> PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2)</span><br><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 17ed4e3..6b887d3 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -1,5 +1,5 @@</span><br><span> AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/</span><br><span style="color: hsl(0, 100%, 40%);">-AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(PCAP_CFLAGS) $(LIBGNUTLS_CFLAGS)</span><br><span style="color: hsl(120, 100%, 40%);">+AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOGB_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(PCAP_CFLAGS) $(LIBGNUTLS_CFLAGS)</span><br><span> </span><br><span> bin_PROGRAMS = osmo-pcap-client osmo-pcap-server</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcap/+/26266">change 26266</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcap/+/26266"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcap </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 </div>
<div style="display:none"> Gerrit-Change-Number: 26266 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>