<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26248">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">spelling fixes in comments<br><br>Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f<br>---<br>M src/ipa.c<br>M src/m3ua.c<br>M src/osmo_ss7.c<br>M src/sccp_sclc.c<br>M src/sccp_scoc.c<br>M src/sccp_scrc.c<br>6 files changed, 21 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/48/26248/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipa.c b/src/ipa.c</span><br><span>index 5b1eb54..8daa5e0 100644</span><br><span>--- a/src/ipa.c</span><br><span>+++ b/src/ipa.c</span><br><span>@@ -135,7 +135,7 @@</span><br><span> {</span><br><span> struct osmo_ss7_as *as;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* in the IPA case, weassume there is a 1:1 mapping between the</span><br><span style="color: hsl(120, 100%, 40%);">+ /* in the IPA case, we assume there is a 1:1 mapping between the</span><br><span> * ASP and the AS. An AS without ASP means there is no</span><br><span> * connection, and an ASP without AS means that we don't (yet?)</span><br><span> * know the identity of the peer */</span><br><span>@@ -301,7 +301,7 @@</span><br><span> OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA);</span><br><span> </span><br><span> /* osmo_ipa_process_msg() will already have verified length</span><br><span style="color: hsl(0, 100%, 40%);">- * consistency and set up l2h poiter */</span><br><span style="color: hsl(120, 100%, 40%);">+ * consistency and set up l2h pointer */</span><br><span> hh = (struct ipaccess_head *) msg->l1h;</span><br><span> </span><br><span> switch (hh->proto) {</span><br><span>diff --git a/src/m3ua.c b/src/m3ua.c</span><br><span>index 26acc1b..741063c 100644</span><br><span>--- a/src/m3ua.c</span><br><span>+++ b/src/m3ua.c</span><br><span>@@ -449,7 +449,7 @@</span><br><span> }</span><br><span> </span><br><span> /***********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Transmitting M3UA messsages to SCTP</span><br><span style="color: hsl(120, 100%, 40%);">+ * Transmitting M3UA messages to SCTP</span><br><span> ***********************************************************************/</span><br><span> </span><br><span> /* Convert M3UA from xua_msg to msgb and set PPID/stream */</span><br><span>@@ -512,7 +512,7 @@</span><br><span> }</span><br><span> </span><br><span> /***********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Receiving M3UA messsages from SCTP</span><br><span style="color: hsl(120, 100%, 40%);">+ * Receiving M3UA messages from SCTP</span><br><span> ***********************************************************************/</span><br><span> </span><br><span> /* obtain the destination point code from a M3UA message in XUA fmt * */</span><br><span>@@ -694,7 +694,7 @@</span><br><span> OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA);</span><br><span> </span><br><span> /* caller owns msg memory, we shall neither free it here nor</span><br><span style="color: hsl(0, 100%, 40%);">- * keep references beyond the executin of this function and its</span><br><span style="color: hsl(120, 100%, 40%);">+ * keep references beyond the execution of this function and its</span><br><span> * callees */</span><br><span> </span><br><span> xua = xua_from_msg(M3UA_VERSION, msgb_length(msg), msgb_data(msg));</span><br><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 22e3c37..be39f8e 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -615,7 +615,7 @@</span><br><span> * SS7 Link</span><br><span> ***********************************************************************/</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! \brief Destryo SS7 Link</span><br><span style="color: hsl(120, 100%, 40%);">+/*! \brief Destroy SS7 Link</span><br><span> * \param[in] link SS7 Link to be destroyed */</span><br><span> void osmo_ss7_link_destroy(struct osmo_ss7_link *link)</span><br><span> {</span><br><span>@@ -897,7 +897,7 @@</span><br><span> ***********************************************************************/</span><br><span> </span><br><span> static const struct rate_ctr_desc ss7_as_rcd[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU receivved" },</span><br><span style="color: hsl(120, 100%, 40%);">+ [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" },</span><br><span> [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" },</span><br><span> };</span><br><span> </span><br><span>@@ -999,7 +999,7 @@</span><br><span> * \param[in] inst SS7 Instance on which we operate</span><br><span> * \param[in] name Name of Application Server</span><br><span> * \param[in] proto Protocol of Application Server</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns pointer to Application Server on suuccess; NULL otherwise */</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns pointer to Application Server on success; NULL otherwise */</span><br><span> struct osmo_ss7_as *</span><br><span> osmo_ss7_as_find_or_create(struct osmo_ss7_instance *inst, const char *name,</span><br><span> enum osmo_ss7_asp_protocol proto)</span><br><span>@@ -1201,7 +1201,7 @@</span><br><span> * \param[in] talloc_ctx talloc context used to allocate new addresses.</span><br><span> * \param[in] hosts Array of strings containing IP addresses.</span><br><span> * \param[in] host_cnt Number of strings in hosts</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns 0 on success; negtive otherwise */</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns 0 on success; negative otherwise */</span><br><span> int osmo_ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char* const* hosts, size_t host_cnt)</span><br><span> {</span><br><span> int i = 0;</span><br><span>@@ -1231,7 +1231,7 @@</span><br><span> }</span><br><span> </span><br><span> /*! \brief Append (copy) address to a given ASP peer. Previous addresses are kept.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] peer Application Server Process peer the address is appened to.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] peer Application Server Process peer the address is appended to.</span><br><span> * \param[in] talloc_ctx talloc context used to allocate new address.</span><br><span> * \param[in] host string containing an IP addresses.</span><br><span> * \returns 0 on success; negative otherwise */</span><br><span>diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c</span><br><span>index 218fb56..186efbd 100644</span><br><span>--- a/src/sccp_sclc.c</span><br><span>+++ b/src/sccp_sclc.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span> * However, all SCCP features can be expressed in SUA.</span><br><span> *</span><br><span> * The code only supports Class 2. No support for Class 3 is intended,</span><br><span style="color: hsl(0, 100%, 40%);">- * but patches are of course alwys welcome.</span><br><span style="color: hsl(120, 100%, 40%);">+ * but patches are of course always welcome.</span><br><span> *</span><br><span> * Missing other features:</span><br><span> * * Segmentation/Reassembly support</span><br><span>@@ -119,7 +119,7 @@</span><br><span> * The caller is required to free oph->msg, otherwise the same as sccp_sclc_user_sap_down().</span><br><span> * \param[in] scu SCCP User who is sending the primitive</span><br><span> * \param[on] oph Osmocom primitive header of the primitive</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns 0 on success; negtive in case of error */</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns 0 on success; negative in case of error */</span><br><span> int sccp_sclc_user_sap_down_nofree(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph)</span><br><span> {</span><br><span> struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph;</span><br><span>@@ -143,7 +143,7 @@</span><br><span> * Implies a msgb_free(oph->msg), otherwise the same as sccp_sclc_user_sap_down_nofree().</span><br><span> * \param[in] scu SCCP User who is sending the primitive</span><br><span> * \param[on] oph Osmocom primitive header of the primitive</span><br><span style="color: hsl(0, 100%, 40%);">- * \returns 0 on success; negtive in case of error */</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns 0 on success; negative in case of error */</span><br><span> int sccp_sclc_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph)</span><br><span> {</span><br><span> struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph;</span><br><span>diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c</span><br><span>index 244e6d3..5f109b3 100644</span><br><span>--- a/src/sccp_scoc.c</span><br><span>+++ b/src/sccp_scoc.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span> * However, all SCCP features can be expressed in SUA.</span><br><span> *</span><br><span> * The code only supports Class 2. No support for Class 3 is intended,</span><br><span style="color: hsl(0, 100%, 40%);">- * but patches are of course alwys welcome.</span><br><span style="color: hsl(120, 100%, 40%);">+ * but patches are of course always welcome.</span><br><span> *</span><br><span> * Missing other features:</span><br><span> * * Segmentation/Reassembly support</span><br><span>@@ -80,7 +80,7 @@</span><br><span> /* remote point code */</span><br><span> uint32_t remote_pc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* local/remote addresses and identiies */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* local/remote addresses and identities */</span><br><span> struct osmo_sccp_addr calling_addr;</span><br><span> struct osmo_sccp_addr called_addr;</span><br><span> /* SCCP connection identifier. Only relevant across the SCCP User SAP,</span><br><span>@@ -90,7 +90,7 @@</span><br><span> /* SCCP Remote Connection Reference. Allocated by the remote</span><br><span> * SCCP stack to uniquely identify a SCCP connection on its end.</span><br><span> * We don't interpret it, but simply cache it here so we can use</span><br><span style="color: hsl(0, 100%, 40%);">- * it whever sending data to the peer. Only relevant over the</span><br><span style="color: hsl(120, 100%, 40%);">+ * it whenever sending data to the peer. Only relevant over the</span><br><span> * wire, not to be used across the SCCP user SAP */</span><br><span> uint32_t remote_ref;</span><br><span> </span><br><span>@@ -1521,7 +1521,7 @@</span><br><span> xua_msg_free(xua);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* process received message for unasigned local reference */</span><br><span style="color: hsl(120, 100%, 40%);">+/* process received message for unassigned local reference */</span><br><span> static void sccp_scoc_rx_unass_local_ref(struct osmo_sccp_instance *inst,</span><br><span> struct xua_msg *xua)</span><br><span> {</span><br><span>@@ -1631,7 +1631,7 @@</span><br><span> /* we basically try to convert the SUA message into an event,</span><br><span> * and then dispatch the event to the connection-specific FSM.</span><br><span> * If it is a CORE (Connect REquest), we create the connection</span><br><span style="color: hsl(0, 100%, 40%);">- * (and imlpicitly its FSM) first */</span><br><span style="color: hsl(120, 100%, 40%);">+ * (and implicitly its FSM) first */</span><br><span> </span><br><span> if (xua->hdr.msg_type == SUA_CO_CORE) {</span><br><span> scu = sccp_find_user(inst, xua);</span><br><span>diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c</span><br><span>index 1da3890..be23c21 100644</span><br><span>--- a/src/sccp_scrc.c</span><br><span>+++ b/src/sccp_scrc.c</span><br><span>@@ -85,7 +85,7 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* 2) wrap into MTP-TRANSFER.req primtiive */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 2) wrap into MTP-TRANSFER.req primitive */</span><br><span> msg->l2h = msg->data;</span><br><span> omp = (struct osmo_mtp_prim *) msgb_push(msg, sizeof(*omp));</span><br><span> osmo_prim_init(&omp->oph, MTP_SAP_USER,</span><br><span>@@ -109,7 +109,7 @@</span><br><span> return osmo_ss7_user_mtp_xfer_req(s7i, omp);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Gererate MTP-TRANSFER.req from xUA message */</span><br><span style="color: hsl(120, 100%, 40%);">+/* Generate MTP-TRANSFER.req from xUA message */</span><br><span> static int gen_mtp_transfer_req_xua(struct osmo_sccp_instance *inst,</span><br><span> struct xua_msg *xua,</span><br><span> const struct osmo_sccp_addr *called)</span><br><span>@@ -230,7 +230,7 @@</span><br><span> /* Connection Oriented? */</span><br><span> if (sua_is_connectionless(xua)) {</span><br><span> /* TODO: Perform Capability Test */</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: Canges Needed? */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: Changes Needed? */</span><br><span> if (0) {</span><br><span> /* Changes Needed -> SCLC */</span><br><span> return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26248">change 26248</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26248"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f </div>
<div style="display:none"> Gerrit-Change-Number: 26248 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>