<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26243">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[overpower] By default, permit only for speech channels using AMR<br><br>Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17<br>Related: SYS#5319<br>---<br>M doc/manuals/chapters/power_control.adoc<br>M src/osmo-bsc/bts.c<br>M src/osmo-bsc/bts_vty.c<br>M tests/acch_overpower.vty<br>4 files changed, 25 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc</span><br><span>index 7200b0e..f5f94f6 100644</span><br><span>--- a/doc/manuals/chapters/power_control.adoc</span><br><span>+++ b/doc/manuals/chapters/power_control.adoc</span><br><span>@@ -604,14 +604,17 @@</span><br><span> bts 0</span><br><span> overpower dl-acch 2 <1></span><br><span> overpower rxqual 4 <2></span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode any <3></span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode speech-amr <3></span><br><span> ----</span><br><span> <1> Overpower of maximum 2 dB for both SACCH and FACCH.</span><br><span> <2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%).</span><br><span style="color: hsl(0, 100%, 40%);">-<3> Permit TOP for any kinds of dedicated channels.</span><br><span style="color: hsl(120, 100%, 40%);">+<3> Permit TOP only for speech channels using AMR codec.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-It's also possible to enable TOP only for FACCH or SACCH selectively, or</span><br><span style="color: hsl(0, 100%, 40%);">-or keep it enabled permanently regardless of the reported RxQual:</span><br><span style="color: hsl(120, 100%, 40%);">+For advanced use cases, OsmoBSC can be configured to:</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+* enable TOP only for FACCH or SACCH selectively, and/or</span><br><span style="color: hsl(120, 100%, 40%);">+* keep TOP enabled permanently regardless of the reported RxQual, and/or</span><br><span style="color: hsl(120, 100%, 40%);">+* permit TOP for any kind of dedicated channels.</span><br><span> </span><br><span> ----</span><br><span> OsmoBSC(config-net-bts)# overpower ?</span><br><span>@@ -621,6 +624,10 @@</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# overpower rxqual 0?</span><br><span> 0 BER >= 0% (always on)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# overpower chan-mode ?</span><br><span style="color: hsl(120, 100%, 40%);">+ speech-amr Speech channels using AMR codec (default)</span><br><span style="color: hsl(120, 100%, 40%);">+ any Any kind of channel mode</span><br><span> ----</span><br><span> </span><br><span> These parameters are indicated to the BTS during a logical channel activation</span><br><span>diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c</span><br><span>index 0fdb636..8af1254 100644</span><br><span>--- a/src/osmo-bsc/bts.c</span><br><span>+++ b/src/osmo-bsc/bts.c</span><br><span>@@ -401,6 +401,9 @@</span><br><span> bts->rep_acch_cap.rxqual = 4;</span><br><span> bts->top_acch_cap.rxqual = 4;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Permit ACCH overpower only for speech channels using AMR */</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->top_acch_chan_mode = TOP_ACCH_CHAN_MODE_SPEECH_V3;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* MS Power Control parameters (defaults) */</span><br><span> power_ctrl_params_def_reset(&bts->ms_power_ctrl, GSM_PWR_CTRL_DIR_UL);</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c</span><br><span>index 2da789a..0c7259b 100644</span><br><span>--- a/src/osmo-bsc/bts_vty.c</span><br><span>+++ b/src/osmo-bsc/bts_vty.c</span><br><span>@@ -830,8 +830,8 @@</span><br><span> "overpower chan-mode (speech-amr|any)",</span><br><span> TOP_ACCH_STR</span><br><span> "Allow temporary overpower for specific Channel mode(s)\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Speech channels using AMR codec\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Any kind of channel mode (default)\n")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Speech channels using AMR codec (default)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Any kind of channel mode\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>diff --git a/tests/acch_overpower.vty b/tests/acch_overpower.vty</span><br><span>index d2b87ef..70090a4 100644</span><br><span>--- a/tests/acch_overpower.vty</span><br><span>+++ b/tests/acch_overpower.vty</span><br><span>@@ -31,21 +31,21 @@</span><br><span> ...</span><br><span> overpower dl-acch 2</span><br><span> overpower rxqual 4</span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode any</span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode speech-amr</span><br><span> ...</span><br><span> OsmoBSC(config-net-bts)# overpower dl-sacch 3</span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span> ...</span><br><span> overpower dl-sacch 3</span><br><span> overpower rxqual 4</span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode any</span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode speech-amr</span><br><span> ...</span><br><span> OsmoBSC(config-net-bts)# overpower dl-facch 4</span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span> ...</span><br><span> overpower dl-facch 4</span><br><span> overpower rxqual 4</span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode any</span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode speech-amr</span><br><span> ...</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# overpower rxqual ?</span><br><span>@@ -62,25 +62,25 @@</span><br><span> ...</span><br><span> overpower dl-facch 4</span><br><span> overpower rxqual 0</span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode any</span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode speech-amr</span><br><span> ...</span><br><span> OsmoBSC(config-net-bts)# overpower rxqual 7</span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span> ...</span><br><span> overpower dl-facch 4</span><br><span> overpower rxqual 7</span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode any</span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode speech-amr</span><br><span> ...</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# overpower chan-mode ?</span><br><span style="color: hsl(0, 100%, 40%);">- speech-amr Speech channels using AMR codec</span><br><span style="color: hsl(0, 100%, 40%);">- any Any kind of channel mode (default)</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# overpower chan-mode speech-amr</span><br><span style="color: hsl(120, 100%, 40%);">+ speech-amr Speech channels using AMR codec (default)</span><br><span style="color: hsl(120, 100%, 40%);">+ any Any kind of channel mode</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# overpower chan-mode any</span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span> ...</span><br><span> overpower dl-facch 4</span><br><span> overpower rxqual 7</span><br><span style="color: hsl(0, 100%, 40%);">- overpower chan-mode speech-amr</span><br><span style="color: hsl(120, 100%, 40%);">+ overpower chan-mode any</span><br><span> ...</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# no overpower dl-acch</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26243">change 26243</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26243"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 </div>
<div style="display:none"> Gerrit-Change-Number: 26243 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>