<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26250">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_dl_ass_fsm: Drop unsued X2000 timer callback<br><br>That timer is only relevant for transmission of Packet Access Reject,<br>which happens only for Uplink assignment, and hence is only set in the<br>timer of tbf_ul_ass_fsm, never in tbf_dl_ass_fsm. This is probably a<br>copy-paste artifact when implementing both FSMs.<br><br>Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b<br>---<br>M src/tbf_dl_ass_fsm.c<br>1 file changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c</span><br><span>index 1d44c91..a5948e7 100644</span><br><span>--- a/src/tbf_dl_ass_fsm.c</span><br><span>+++ b/src/tbf_dl_ass_fsm.c</span><br><span>@@ -185,11 +185,7 @@</span><br><span> </span><br><span> static int tbf_dl_ass_fsm_timer_cb(struct osmo_fsm_inst *fi)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   struct tbf_dl_ass_fsm_ctx *ctx = (struct tbf_dl_ass_fsm_ctx *)fi->priv;</span><br><span>   switch (fi->T) {</span><br><span style="color: hsl(0, 100%, 40%);">-     case -2000:</span><br><span style="color: hsl(0, 100%, 40%);">-             tbf_free(ctx->tbf);</span><br><span style="color: hsl(0, 100%, 40%);">-          break;</span><br><span>       default:</span><br><span>             OSMO_ASSERT(0);</span><br><span>      }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26250">change 26250</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26250"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b </div>
<div style="display:none"> Gerrit-Change-Number: 26250 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>