<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25767">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_bsc_main: call bootstrap_bts when OML TEI comes up<br><br>At the moment check_bts and bootstrap_bts is called only once on startup.<br>When a new BTS is set up during runtime bootstrap_bts, nor check_bts is<br>called. This means that some parameters of the BTS stay uninitalized<br>until osmo-bsc is restarted. Lets rather call check_bts() and then<br>bootstrap_bts() when the OML TEI of the BTS comes up.<br><br>Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85<br>Related: SYS#5369<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 17 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index fae2ef2..ae9bd69 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -477,6 +477,7 @@</span><br><span> {</span><br><span>     struct input_signal_data *isd = signal_data;</span><br><span>         struct gsm_bts_trx *trx = isd->trx;</span><br><span style="color: hsl(120, 100%, 40%);">+        int rc;</span><br><span> </span><br><span>  if (subsys != SS_L_INPUT)</span><br><span>            return -EINVAL;</span><br><span>@@ -489,9 +490,24 @@</span><br><span>                       /* Generate Mobile Allocation bit-masks for all timeslots.</span><br><span>                    * This needs to be done here, because it's used for TS configuration. */</span><br><span>                        generate_ma_for_bts(trx->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+                     /* Check parameters and apply vty config dependent parameters */</span><br><span style="color: hsl(120, 100%, 40%);">+                      rc = check_bts(trx->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+                  if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                              LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap BTS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                   trx->bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+                             return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+                    }</span><br><span style="color: hsl(120, 100%, 40%);">+                     bootstrap_bts(trx->bts);</span><br><span>          }</span><br><span style="color: hsl(0, 100%, 40%);">-               if (isd->link_type == E1INP_SIGN_RSL)</span><br><span style="color: hsl(120, 100%, 40%);">+              if (isd->link_type == E1INP_SIGN_RSL) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    rc = check_bts(trx->bts);</span><br><span style="color: hsl(120, 100%, 40%);">+                  if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                              LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap RSL\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                   trx->bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+                             return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+                    }</span><br><span>                    bootstrap_rsl(trx);</span><br><span style="color: hsl(120, 100%, 40%);">+           }</span><br><span>            break;</span><br><span>       case S_L_INP_TEI_DN:</span><br><span>                 LOG_TRX(trx, DLMI, LOGL_ERROR, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25767">change 25767</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25767"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 </div>
<div style="display:none"> Gerrit-Change-Number: 25767 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>