<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169<br><br>I cannot reproduce the issue in my local system with docker, probabluy<br>due to different performance from jenkins builder. It triggers almost<br>every time in jenkins nightly TTCN3 PCU_tests though.<br>A similar fix was already introduced recently for TC_n3105_max_t3195<br>since PCU started submitting empty (idle) blocks when there's no TBF<br>listening on that PDCH. We need to update the test to account for that,<br>since our TTCN3 timers are not necessarily exactly matching the one at<br>the PCU side.<br><br>Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index c347761..5bc2959 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1524,6 +1524,9 @@</span><br><span>                                         block_nr := nr.blk_nr));</span><br><span>           repeat;</span><br><span>      }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* We may already receive empty (idle) blocks before our own TTCN3 timer</span><br><span style="color: hsl(120, 100%, 40%);">+       * triggers due to the TBF being released. Keep going until our T_3169 triggers. */</span><br><span style="color: hsl(120, 100%, 40%);">+   [mp_osmo_pcu_newer_than_0_9_0 and n3101 == N3101_MAX + 1] as_pcuif_rx_ignore_empty(nr);</span><br><span>      [] T_3169.timeout {</span><br><span>          log("T_3169 expired");</span><br><span>             /* Done in alt */</span><br><span>@@ -1622,6 +1625,7 @@</span><br><span>            f_shutdown(__BFILE__, __LINE__);</span><br><span>     }</span><br><span>    [] as_ms_rx_ignore_dummy(ms, nr);</span><br><span style="color: hsl(120, 100%, 40%);">+     [] as_pcuif_rx_ignore_empty(nr);</span><br><span>     [T_3169.running] T_3169.timeout {</span><br><span>            log("T_3169 timeout");</span><br><span>             /* Done in alt, wait for pending RTS initiated previously in</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221">change 26221</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 </div>
<div style="display:none"> Gerrit-Change-Number: 26221 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>