<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/26224">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Do not mention deprecated -M / --mncc-sock-path options<br><br>Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5<br>---<br>M doc/manuals/chapters/running.adoc<br>M src/osmo-msc/msc_main.c<br>2 files changed, 4 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/24/26224/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc</span><br><span>index 445a164..988b84d 100644</span><br><span>--- a/doc/manuals/chapters/running.adoc</span><br><span>+++ b/doc/manuals/chapters/running.adoc</span><br><span>@@ -5,7 +5,7 @@</span><br><span> </span><br><span> === SYNOPSIS</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH']</span><br><span style="color: hsl(120, 100%, 40%);">+*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE']</span><br><span> </span><br><span> === OPTIONS</span><br><span> </span><br><span>@@ -37,11 +37,6 @@</span><br><span>     <<logging>> for more information.</span><br><span> *-l, --database 'DATABASE'*::</span><br><span>       Specify the file name of the SQLite3 database to use as SMS storage</span><br><span style="color: hsl(0, 100%, 40%);">-*-M, --mncc-sock-path*::</span><br><span style="color: hsl(0, 100%, 40%);">-     Enable the MNCC socket for an external MNCC handler. See</span><br><span style="color: hsl(0, 100%, 40%);">-        <<mncc>> for further information.</span><br><span style="color: hsl(0, 100%, 40%);">-*-m, --mncc-sock*::</span><br><span style="color: hsl(0, 100%, 40%);">-        Same as option -M (deprecated).</span><br><span> </span><br><span> </span><br><span> === Multiple instances</span><br><span>diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c</span><br><span>index cd91d54..07d76dd 100644</span><br><span>--- a/src/osmo-msc/msc_main.c</span><br><span>+++ b/src/osmo-msc/msc_main.c</span><br><span>@@ -131,7 +131,6 @@</span><br><span>     printf("  -T --timestamp             Prefix every log line with a timestamp.\n");</span><br><span>  printf("  -V --version               Print the version of OsmoMSC.\n");</span><br><span>    printf("  -e --log-level number      Set a global loglevel.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-      printf("  -M --mncc-sock-path PATH   Disable built-in MNCC handler and offer socket.\n");</span><br><span> </span><br><span>      printf("\nVTY reference generation:\n");</span><br><span>   printf("     --vty-ref-mode MODE     VTY reference generation mode (e.g. 'expert').\n");</span><br><span>@@ -178,7 +177,7 @@</span><br><span>                     {"timestamp", 0, 0, 'T'},</span><br><span>                  {"version", 0, 0, 'V' },</span><br><span>                   {"log-level", 1, 0, 'e'},</span><br><span style="color: hsl(0, 100%, 40%);">-                     {"mncc-sock-path", 1, 0, 'M'},</span><br><span style="color: hsl(120, 100%, 40%);">+                      {"mncc-sock-path", 1, 0, 'M'}, /* deprecated */</span><br><span>                    {"no-dbcounter", 0, 0, 'C'}, /* deprecated */</span><br><span>                      {"vty-ref-mode", 1, &long_option, 1},</span><br><span>                  {"vty-ref-xml", 0, &long_option, 2},</span><br><span>@@ -221,6 +220,8 @@</span><br><span>                     break;</span><br><span>               case 'M':</span><br><span>                    msc_cmdline_config.mncc_sock_path = optarg;</span><br><span style="color: hsl(120, 100%, 40%);">+                   fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY "</span><br><span style="color: hsl(120, 100%, 40%);">+                               "parameter 'msc' / 'mncc external %s' instead.\n", c, optarg);</span><br><span>                     break;</span><br><span>               case 'C':</span><br><span>                    fprintf(stderr, "-C is deprecated and does nothing.");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/26224">change 26224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/26224"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 </div>
<div style="display:none"> Gerrit-Change-Number: 26224 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>