<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/libusrp/+/19675">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py">File firmware/src/common/build_eeprom.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py@87">Patch Set #2, Line 87:</a> <code style="font-family:monospace,monospace">key=lambda a: a.addr</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Not sure if this change is correct.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">looks correct according to https://stackoverflow.com/a/403426</p><p style="white-space: pre-wrap; word-wrap: break-word;">also I've verified that the generated files are the same in both versions.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  $ git checkout master<br>  $ autoreconf -fi<br>  $ ./configure<br>  $ make<br>  $ cp firmware/src/usrp2/burn-usrp* /tmp/<br>  $ make distclean<br>  $ git review -d 19675<br>  $ autoreconf -fi<br>  $ ./configure<br>  $ make<br>  $ diff -s /tmp/burn-usrp2-eeprom firmware/src/usrp2/burn-usrp2-eeprom<br>  Files /tmp/burn-usrp2-eeprom and firmware/src/usrp2/burn-usrp2-eeprom are identical<br>  $ diff -s /tmp/burn-usrp4-eeprom firmware/src/usrp2/burn-usrp4-eeprom<br>  Files /tmp/burn-usrp4-eeprom and firmware/src/usrp2/burn-usrp4-eeprom are identical</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libusrp/+/19675">change 19675</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libusrp/+/19675"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libusrp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547 </div>
<div style="display:none"> Gerrit-Change-Number: 19675 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: roox <mardnh@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Nov 2021 10:48:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>