<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26207">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one<br><br>Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9<br>---<br>M src/tbf_dl_ass_fsm.c<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/26207/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c</span><br><span>index 37ced61..b7b3d88 100644</span><br><span>--- a/src/tbf_dl_ass_fsm.c</span><br><span>+++ b/src/tbf_dl_ass_fsm.c</span><br><span>@@ -77,9 +77,6 @@</span><br><span>                 return NULL;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (new_dl_tbf == as_dl_tbf(ctx->tbf))</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGPTBF(ctx->tbf, LOGL_DEBUG, "New and old TBF are the same.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>       if (old_tfi_is_valid && ms_tlli(ms) == GSM_RESERVED_TMSI) {</span><br><span>          LOGPTBF(ctx->tbf, LOGL_ERROR,</span><br><span>                       "The old TFI is not assigned and there is no TLLI. New TBF %s\n",</span><br><span>@@ -99,7 +96,12 @@</span><br><span>   };</span><br><span>   bitvec_unhex(&bv, DUMMY_VEC);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGPTBF((struct gprs_rlcmac_tbf *)new_dl_tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+     if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        tbf_name((const struct gprs_rlcmac_tbf *)new_tbf));</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t);</span><br><span>  write_packet_downlink_assignment(mac_control_block, old_tfi_is_valid,</span><br><span>                tbf_tfi(ctx->tbf), (tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26207">change 26207</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26207"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 </div>
<div style="display:none"> Gerrit-Change-Number: 26207 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>