<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26208">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent<br><br>If by the time the PktDlAss is to be scheduled by the scheduler the DL<br>TBF is gone, the FSM will abort the assignment and go back to state<br>NONE.<br>However, the transition was missing, ending up in the scheduler trying<br>to schedule the message unsuccessfuly lots of times per second, clogging<br>the logs and disrupting normal operation.<br><br>Related: OS#5293<br>Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647<br>---<br>M src/tbf_dl_ass_fsm.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/26208/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c</span><br><span>index b7b3d88..18db659 100644</span><br><span>--- a/src/tbf_dl_ass_fsm.c</span><br><span>+++ b/src/tbf_dl_ass_fsm.c</span><br><span>@@ -208,7 +208,9 @@</span><br><span>       },</span><br><span>   [TBF_DL_ASS_SEND_ASS] = {</span><br><span>            .in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG),</span><br><span style="color: hsl(0, 100%, 40%);">-            .out_state_mask = X(TBF_DL_ASS_WAIT_ACK),</span><br><span style="color: hsl(120, 100%, 40%);">+             .out_state_mask =</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(TBF_DL_ASS_WAIT_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(TBF_DL_ASS_NONE),</span><br><span>          .name = "SEND_ASS",</span><br><span>                .action = st_send_ass,</span><br><span>       },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26208">change 26208</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26208"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 </div>
<div style="display:none"> Gerrit-Change-Number: 26208 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>