<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26198">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: Drop previous UL TBF from MS who sent PktResReq through SBA<br><br>If the MS has a pending UL TBF but we just received a PktResReq on an<br>allocated SBA from it (same TLLI, hence same MS), then it means it<br>allocated the SBA through RACH req and hence it was on CCCH. That means<br>it was not active on any PDCH, hence for sure the previous UL TBF can be<br>dropped.<br><br>Related: OS#5293<br><br>Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c<br>---<br>M src/pdch.cpp<br>1 file changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/26198/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 4d82ab1..c48b078 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -680,6 +680,16 @@</span><br><span>                                 "MS requests UL TBF throguh SBA\n", fn);</span><br><span>                   ms_set_ta(ms, sba->ta);</span><br><span>                   sba_free(sba);</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* If MS identified by TLLI sent us a PktResReq through SBA, it means it came</span><br><span style="color: hsl(120, 100%, 40%);">+                  * from CCCH, so it's for sure not using previous UL</span><br><span style="color: hsl(120, 100%, 40%);">+                       * TBF; drop it if it still exits on our end: */</span><br><span style="color: hsl(120, 100%, 40%);">+                      if ((ul_tbf = ms_ul_tbf(ms))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                               /* Get rid of previous finished UL TBF before providing a new one */</span><br><span style="color: hsl(120, 100%, 40%);">+                          LOGPTBFUL(ul_tbf, LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                                          "Got PACKET RESOURCE REQ while TBF not finished, killing pending UL TBF\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                              tbf_free(ul_tbf);</span><br><span style="color: hsl(120, 100%, 40%);">+                             ul_tbf = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+                        }</span><br><span>                    /* MS seized the PDCH answering on the SBA: */</span><br><span>                       bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);</span><br><span>                         break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26198">change 26198</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26198"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c </div>
<div style="display:none"> Gerrit-Change-Number: 26198 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>