<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26181">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, approved
  dexter: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ts_alloc: rename function to clraify what it does<br><br>The function updates nothing, so it's misleading. It simply counts<br>slots, so let's call it like that.<br><br>Change-Id: I55954321d6f2b5e755177a8829512da371e934aa<br>---<br>M src/gprs_rlcmac_ts_alloc.cpp<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp</span><br><span>index b69d735..13e6440 100644</span><br><span>--- a/src/gprs_rlcmac_ts_alloc.cpp</span><br><span>+++ b/src/gprs_rlcmac_ts_alloc.cpp</span><br><span>@@ -661,7 +661,7 @@</span><br><span>  *  \param[out] slotcount Number of TS in use</span><br><span>  *  \param[out] avail_count Number of reserved TS</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-static void update_slot_counters(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count)</span><br><span style="color: hsl(120, 100%, 40%);">+static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count)</span><br><span> {</span><br><span>   (*slotcount) = pcu_bitcount(slots);</span><br><span>  (*avail_count) = pcu_bitcount(reserved_slots);</span><br><span>@@ -910,7 +910,7 @@</span><br><span>         /* Step 3b: Derive the slot set for a given direction */</span><br><span>     if (tbf->direction == GPRS_RLCMAC_DL_TBF) {</span><br><span>               dl_slots = rc;</span><br><span style="color: hsl(0, 100%, 40%);">-          update_slot_counters(dl_slots, reserved_dl_slots, &slotcount, &avail_count);</span><br><span style="color: hsl(120, 100%, 40%);">+          count_slots(dl_slots, reserved_dl_slots, &slotcount, &avail_count);</span><br><span>  } else {</span><br><span>             rc = allocate_usf(trx, rc, dl_slots, usf);</span><br><span>           if (rc < 0)</span><br><span>@@ -919,7 +919,7 @@</span><br><span>                 ul_slots = rc;</span><br><span>               reserved_ul_slots = ul_slots;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               update_slot_counters(ul_slots, reserved_ul_slots, &slotcount, &avail_count);</span><br><span style="color: hsl(120, 100%, 40%);">+          count_slots(ul_slots, reserved_ul_slots, &slotcount, &avail_count);</span><br><span>  }</span><br><span> </span><br><span>        first_ts = ffs(rc) - 1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26181">change 26181</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26181"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I55954321d6f2b5e755177a8829512da371e934aa </div>
<div style="display:none"> Gerrit-Change-Number: 26181 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>