<p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h">File include/osmocom/mgcp/mgcp_conn.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h@a134">Patch Set #5, Line 134:</a> <code style="font-family:monospace,monospace">/* RTP connection related counters */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So you are removing the counters from here but still using them immediatelly afterwards? how is that supposed to work? are they included from somewhere?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h@27">Patch Set #5, Line 27:</a> <code style="font-family:monospace,monospace">#include <osmocom/mgcp/mgcp_network.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't see mgcp/mgcp_ratectr.h included here and that's where you moved the enum?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h">File include/osmocom/mgcp/mgcp_ratectr.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h@15">Patch Set #5, Line 15:</a> <code style="font-family:monospace,monospace">};</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">yo should perhaps move the rate_ctr dscriptions here too?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c">File src/libosmo-mgcp/mgcp_endp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c@a129">Patch Set #5, Line 129:</a> <code style="font-family:monospace,monospace">           osmo_stat_item_dec(osmo_stat_item_group_get_item(endp->trunk->stats.common,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">so we lost these counters?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190">change 26190</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/26190"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 </div>
<div style="display:none"> Gerrit-Change-Number: 26190 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Nov 2021 12:50:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>