<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSM_RR_Types: remove misleading PADDING attributes<br><br>Unfortunately, TITAN has a weird (and often unusable) model of<br>defining padding in records.  According to its reference guide,<br>padding length is counted from the beginning of the message.<br>So if the 'MeasurementResults' is a part of another record, and<br>there are other fields preceeding it, the encoded representation<br>of the 'MeasurementResults' may still be shorter than 16 octets.<br><br>Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2<br>---<br>M library/GSM_RR_Types.ttcn<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index f7b00e1..f45784c 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -650,8 +650,7 @@</span><br><span>           NcellReports    ncell_reports optional</span><br><span>       } with { variant (no_ncell_m) "LENGTHTO(ncell_reports)"</span><br><span>             variant (no_ncell_m) "UNIT(elements)"</span><br><span style="color: hsl(0, 100%, 40%);">-                 variant "PADDING(yes)"</span><br><span style="color: hsl(0, 100%, 40%);">-                variant "FIELDLENGTH(16)"</span><br><span style="color: hsl(120, 100%, 40%);">+           /* FIXME: pad to 16 octets */</span><br><span>       };</span><br><span> </span><br><span>       type record NcellReport {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109">change 26109</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 </div>
<div style="display:none"> Gerrit-Change-Number: 26109 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>