<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26184">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_bsc_main: bootstrap_bts: print errornous ARFCN number<br><br>The function bootstrap_bts verifies that the ARFCN number is within the<br>valid range of the current band. In case of error it prints that the<br>ARFCN is out of range, but it does not print the BTS number, nor the<br>ARFCN number.<br><br>Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/26184/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index 17196e9..a39c109 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -447,32 +447,32 @@</span><br><span>        switch (bts->band) {</span><br><span>      case GSM_BAND_1800:</span><br><span>          if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   LOGP(DNM, LOGL_ERROR, "GSM1800 channel must be between 512-885.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1800 channel (%u) must be between 512-885.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        bts->nr, bts->c0->arfcn);</span><br><span>                      return -EINVAL;</span><br><span>              }</span><br><span>            break;</span><br><span>       case GSM_BAND_1900:</span><br><span>          if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   LOGP(DNM, LOGL_ERROR, "GSM1900 channel must be between 512-810.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                  return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        bts->nr, bts->c0->arfcn);</span><br><span>              }</span><br><span>            break;</span><br><span>       case GSM_BAND_900:</span><br><span>           if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) ||</span><br><span>                  bts->c0->arfcn > 1023)  {</span><br><span style="color: hsl(0, 100%, 40%);">-                  LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 0-124, 955-1023.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                   return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                         bts->nr, bts->c0->arfcn);</span><br><span>              }</span><br><span>            break;</span><br><span>       case GSM_BAND_850:</span><br><span>           if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   LOGP(DNM, LOGL_ERROR, "GSM850 channel must be between 128-251.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                   return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                         bts->nr, bts->c0->arfcn);</span><br><span>              }</span><br><span>            break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DNM, LOGL_ERROR, "Unsupported frequency band.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-               return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr);</span><br><span>       }</span><br><span> </span><br><span>        /* Verify the physical channel mapping */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/26184">change 26184</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/26184"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee </div>
<div style="display:none"> Gerrit-Change-Number: 26184 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>