<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26131">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Log tbf_state when showing a TBF<br><br>That's one of the most important information bits about a TBF when<br>debugging, and it's not shown currently, only when "show ms" is used.<br><br>Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945<br>---<br>M src/pcu_vty_functions.cpp<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp</span><br><span>index 21851df..fb7897d 100644</span><br><span>--- a/src/pcu_vty_functions.cpp</span><br><span>+++ b/src/pcu_vty_functions.cpp</span><br><span>@@ -54,8 +54,9 @@</span><br><span>                tbf->ta(),</span><br><span>                tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL",</span><br><span>           tbf->imsi(), VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-   vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s",</span><br><span style="color: hsl(0, 100%, 40%);">-          tbf->created_ts(), tbf->state_fsm.state_flags,</span><br><span style="color: hsl(120, 100%, 40%);">+  vty_out(vty, " created=%lu state=%s flags=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s",</span><br><span style="color: hsl(120, 100%, 40%);">+               tbf->created_ts(), tbf->state_name(),</span><br><span style="color: hsl(120, 100%, 40%);">+           tbf->state_fsm.state_flags,</span><br><span>               tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH),</span><br><span>              tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH),</span><br><span>             tbf->first_ts,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26131">change 26131</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26131"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945 </div>
<div style="display:none"> Gerrit-Change-Number: 26131 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>