<p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26166">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c">File src/bts_pch_timer.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c@37">Patch Set #2, Line 37:</a> <code style="font-family:monospace,monospace">p->ptmsi != GSM_RESERVED_TMSI</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Above you already ensure that ptmsi != GSM_RESERVED_TMSI, so this check is redundant.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c@87">Patch Set #2, Line 87:</a> <code style="font-family:monospace,monospace">       osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_STRLCPY_ARRAY(p->imsi, imsi);</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26166">change 26166</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26166"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 </div>
<div style="display:none"> Gerrit-Change-Number: 26166 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 08 Nov 2021 18:31:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>